You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "zeroshade (via GitHub)" <gi...@apache.org> on 2024/03/27 18:46:42 UTC
[PR] GH-40733: [Go] Require Go 1.21 or later [arrow]
zeroshade opened a new pull request, #40848:
URL: https://github.com/apache/arrow/pull/40848
<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how
to contribute here:
* [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
-->
### Rationale for this change
Bumping to require Go 1.21 or later as 1.20 is EOL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40733: [Go] Require Go 1.21 or later [arrow]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on code in PR #40848:
URL: https://github.com/apache/arrow/pull/40848#discussion_r1543406313
##########
go/arrow/flight/flightsql/driver/driver_test.go:
##########
@@ -619,6 +619,7 @@ func (s *SqlTestSuite) TestRowsPrematureCloseDuringNextLoop() {
require.NoError(t, err)
require.Equal(t, int64(rowCount), insertedRows)
+ time.Sleep(200 * time.Millisecond)
Review Comment:
Looks like the flaky test was that every so often sqlite didn't fully update itself internally and the select would return 0 rows instead of 6000. Likely some sort of race condition
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40733: [Go] Require Go 1.21 or later [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #40848:
URL: https://github.com/apache/arrow/pull/40848#issuecomment-2027059504
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 950fbb62ce7388aad926c5af5861bf07f7db6de1.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/23235251403) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40733: [Go] Require Go 1.21 or later [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #40848:
URL: https://github.com/apache/arrow/pull/40848#issuecomment-2026404964
@github-actions crossbow submit -g go
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40733: [Go] Require Go 1.21 or later [arrow]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #40848:
URL: https://github.com/apache/arrow/pull/40848#discussion_r1543369892
##########
go/arrow/flight/flightsql/driver/driver_test.go:
##########
@@ -619,6 +619,7 @@ func (s *SqlTestSuite) TestRowsPrematureCloseDuringNextLoop() {
require.NoError(t, err)
require.Equal(t, int64(rowCount), insertedRows)
+ time.Sleep(200 * time.Millisecond)
Review Comment:
What's this for?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40733: [Go] Require Go 1.21 or later [arrow]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #40848:
URL: https://github.com/apache/arrow/pull/40848#issuecomment-2025754883
@kou @lidavidm this is ready for review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40733: [Go] Require Go 1.21 or later [arrow]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade merged PR #40848:
URL: https://github.com/apache/arrow/pull/40848
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40733: [Go] Require Go 1.21 or later [arrow]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #40848:
URL: https://github.com/apache/arrow/pull/40848#discussion_r1543565392
##########
go/arrow/flight/flightsql/driver/driver_test.go:
##########
@@ -619,6 +619,7 @@ func (s *SqlTestSuite) TestRowsPrematureCloseDuringNextLoop() {
require.NoError(t, err)
require.Equal(t, int64(rowCount), insertedRows)
+ time.Sleep(200 * time.Millisecond)
Review Comment:
That...seems like a serious bug if true. More likely I'd say a missed COMMIT or just a race condition where we aren't actually finishing inserting data?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40733: [Go] Require Go 1.21 or later [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40848:
URL: https://github.com/apache/arrow/pull/40848#issuecomment-2023704566
:warning: GitHub issue #40733 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40733: [Go] Require Go 1.21 or later [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #40848:
URL: https://github.com/apache/arrow/pull/40848#discussion_r1542191873
##########
go/arrow/bitutil/bitutil_bytes_go1.19.go:
##########
Review Comment:
Can we remove this because we drop support for Go 1.19?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40733: [Go] Require Go 1.21 or later [arrow]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #40848:
URL: https://github.com/apache/arrow/pull/40848#discussion_r1543566945
##########
go/arrow/flight/flightsql/driver/driver_test.go:
##########
@@ -619,6 +619,7 @@ func (s *SqlTestSuite) TestRowsPrematureCloseDuringNextLoop() {
require.NoError(t, err)
require.Equal(t, int64(rowCount), insertedRows)
+ time.Sleep(200 * time.Millisecond)
Review Comment:
oh well, this driver code from the start was just duplicating adbc for some reason anyways so I'm not too concerned with it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40733: [Go] Require Go 1.21 or later [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40848:
URL: https://github.com/apache/arrow/pull/40848#issuecomment-2026406546
Revision: d72c6d96b071d9a3bb14dc2ac544c764f7876887
Submitted crossbow builds: [ursacomputing/crossbow @ actions-0e90304d93](https://github.com/ursacomputing/crossbow/branches/all?query=actions-0e90304d93)
|Task|Status|
|----|------|
|test-debian-12-go-1.21|[](https://github.com/ursacomputing/crossbow/runs/23224053525)|
|test-debian-12-go-1.22|[](https://github.com/ursacomputing/crossbow/runs/23224053853)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org