You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Torsten Krah (JIRA)" <de...@myfaces.apache.org> on 2006/07/13 17:23:30 UTC
[jira] Created: (TOMAHAWK-542) forceId does not work on dataTable
forceId does not work on dataTable
----------------------------------
Key: TOMAHAWK-542
URL: http://issues.apache.org/jira/browse/TOMAHAWK-542
Project: MyFaces Tomahawk
Type: Bug
Components: Extended Datatable
Versions: 1.1.3
Environment: tomcat 5.5, java 1.5
Reporter: Torsten Krah
Priority: Minor
Using forceId="true" with a extended dataTable still gives me the
generated one - the id gets not forced in the generated output.
t:panelGroup e.g. with forceId works.
According to the docs ( http://myfaces.apache.org/tomahawk/forceId.html ) it should work with all t: components.
kind regards
Torsten
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (TOMAHAWK-542) forceId does not work on dataTable
Posted by "Christopher Hlubek (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/TOMAHAWK-542?page=comments#action_12422406 ]
Christopher Hlubek commented on TOMAHAWK-542:
---------------------------------------------
I've got the same issue for the t:dataList component. If it's initially displayed, the forceId works. After a commandLink was clicked and the view is rendered again, forceId is neglected.
Another issue is, that the t:updateActionListener doesn't work, since the ids are not correct. For example the id is "list" (forceId is used) on the initial view and after a submit the id is something like "form:list".
> forceId does not work on dataTable
> ----------------------------------
>
> Key: TOMAHAWK-542
> URL: http://issues.apache.org/jira/browse/TOMAHAWK-542
> Project: MyFaces Tomahawk
> Issue Type: Bug
> Components: Extended Datatable
> Affects Versions: 1.1.3
> Environment: tomcat 5.5, java 1.5
> Reporter: Torsten Krah
> Priority: Minor
>
> Using forceId="true" with a extended dataTable still gives me the
> generated one - the id gets not forced in the generated output.
> t:panelGroup e.g. with forceId works.
> According to the docs ( http://myfaces.apache.org/tomahawk/forceId.html ) it should work with all t: components.
> kind regards
> Torsten
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (TOMAHAWK-542) forceId does not work on dataTable
Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TOMAHAWK-542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12626751#action_12626751 ]
Leonardo Uribe commented on TOMAHAWK-542:
-----------------------------------------
If you have for example this code (see dataList.jsp on tomahawk examples):
<t:dataList id="data4"
styleClass="standardList"
var="country"
value="#{countryList.countries}"
layout="orderedList"
forceId="true">
<h:inputText value="#{country.name}" />
</t:dataList>
the actual code is this (this was because the getClientId previous code was very old):
<ol id="data4" class="standardList">
<li><input id="data4_0:_idJsp13" name="data4_0:_idJsp13" type="text" value="AUSTRIA" /></li>
<li><input id="data4_1:_idJsp13" name="data4_1:_idJsp13" type="text" value="AZERBAIJAN" /></li>
<li><input id="data4_2:_idJsp13" name="data4_2:_idJsp13" type="text" value="BAHAMAS" /></li>
<li><input id="data4_3:_idJsp13" name="data4_3:_idJsp13" type="text" value="BAHRAIN" /></li>
<li><input id="data4_4:_idJsp13" name="data4_4:_idJsp13" type="text" value="BANGLADESH" /></li>
<li><input id="data4_5:_idJsp13" name="data4_5:_idJsp13" type="text" value="BARBADOS" /></li>
</ol>
the expected html rendered code should be this:
<ol id="data4" class="standardList">
<li><input id="data4:0:_idJsp13" name="data4:0:_idJsp13" type="text" value="AUSTRIA" /></li>
<li><input id="data4:1:_idJsp13" name="data4:1:_idJsp13" type="text" value="AZERBAIJAN" /></li>
<li><input id="data4:2:_idJsp13" name="data4:2:_idJsp13" type="text" value="BAHAMAS" /></li>
<li><input id="data4:3:_idJsp13" name="data4:3:_idJsp13" type="text" value="BAHRAIN" /></li>
<li><input id="data4:4:_idJsp13" name="data4:4:_idJsp13" type="text" value="BANGLADESH" /></li>
<li><input id="data4:5:_idJsp13" name="data4:5:_idJsp13" type="text" value="BARBADOS" /></li>
</ol>
If you have this:
<t:dataList id="data4"
styleClass="standardList"
var="country"
value="#{countryList.countries}"
layout="orderedList">
<h:inputText value="#{country.name}" />
</t:dataList>
The result should be this:
<ol id="_idJsp2:data4" class="standardList">
<li><input id="_idJsp2:data4:0:_idJsp13" name="_idJsp2:data4:0:_idJsp13" type="text" value="AUSTRIA" /></li>
<li><input id="_idJsp2:data4:1:_idJsp13" name="_idJsp2:data4:1:_idJsp13" type="text" value="AZERBAIJAN" /></li>
<li><input id="_idJsp2:data4:2:_idJsp13" name="_idJsp2:data4:2:_idJsp13" type="text" value="BAHAMAS" /></li>
<li><input id="_idJsp2:data4:3:_idJsp13" name="_idJsp2:data4:3:_idJsp13" type="text" value="BAHRAIN" /></li>
<li><input id="_idJsp2:data4:4:_idJsp13" name="_idJsp2:data4:4:_idJsp13" type="text" value="BANGLADESH" /></li>
<li><input id="_idJsp2:data4:5:_idJsp13" name="_idJsp2:data4:5:_idJsp13" type="text" value="BARBADOS" /></li>
</ol>
If you have this:
<t:dataList id="data4"
styleClass="standardList"
var="country"
value="#{countryList.countries}"
layout="orderedList"
>
<t:inputText forceId="true" forceIdIndex="true" value="#{country.name}" />
</t:dataList>
The result should be this:
<ol id="_idJsp2:data4" class="standardList">
<li><input id="_idJsp13[0]" name="_idJsp13[0]" type="text" value="AUSTRIA" /></li>
<li><input id="_idJsp13[1]" name="_idJsp13[1]" type="text" value="AZERBAIJAN" /></li>
<li><input id="_idJsp13[2]" name="_idJsp13[2]" type="text" value="BAHAMAS" /></li>
<li><input id="_idJsp13[3]" name="_idJsp13[3]" type="text" value="BAHRAIN" /></li>
<li><input id="_idJsp13[4]" name="_idJsp13[4]" type="text" value="BANGLADESH" /></li>
<li><input id="_idJsp13[5]" name="_idJsp13[5]" type="text" value="BARBADOS" /></li>
</ol>
The previous behavior is consistent, so it will be applied.
For do this, AbstractHtmlDataList getClientId() method should be removed and moved HtmlComponentUtils.getClientId(this, getRenderer(context), context) related code to HtmlDataTableHack.
With this solution, this issue will be closed, but TOMAHAWK-1316 will be closed as cannot duplicate, because on the latest 1.1.7-SNAPSHOT code the error is not present.
> forceId does not work on dataTable
> ----------------------------------
>
> Key: TOMAHAWK-542
> URL: https://issues.apache.org/jira/browse/TOMAHAWK-542
> Project: MyFaces Tomahawk
> Issue Type: Bug
> Components: Extended Datatable
> Affects Versions: 1.1.3
> Environment: tomcat 5.5, java 1.5
> Reporter: Torsten Krah
> Priority: Minor
> Attachments: HtmlDataList.java, HtmlDataTableHack.java
>
>
> Using forceId="true" with a extended dataTable still gives me the
> generated one - the id gets not forced in the generated output.
> t:panelGroup e.g. with forceId works.
> According to the docs ( http://myfaces.apache.org/tomahawk/forceId.html ) it should work with all t: components.
> kind regards
> Torsten
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TOMAHAWK-542) forceId does not work on dataTable
Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TOMAHAWK-542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12626744#action_12626744 ]
Leonardo Uribe commented on TOMAHAWK-542:
-----------------------------------------
After looking the files, the solution proposed is call HtmlComponentUtils.getClientId(this, getRenderer(context), context); on getClientId method of HtmlDataTableHack. Since this method it is called from AbstractHtmlDataList getClientId, this should be removed from it.
But the method getClientId from AbstractHtmlDataList is bad.
If you have this code:
> forceId does not work on dataTable
> ----------------------------------
>
> Key: TOMAHAWK-542
> URL: https://issues.apache.org/jira/browse/TOMAHAWK-542
> Project: MyFaces Tomahawk
> Issue Type: Bug
> Components: Extended Datatable
> Affects Versions: 1.1.3
> Environment: tomcat 5.5, java 1.5
> Reporter: Torsten Krah
> Priority: Minor
> Attachments: HtmlDataList.java, HtmlDataTableHack.java
>
>
> Using forceId="true" with a extended dataTable still gives me the
> generated one - the id gets not forced in the generated output.
> t:panelGroup e.g. with forceId works.
> According to the docs ( http://myfaces.apache.org/tomahawk/forceId.html ) it should work with all t: components.
> kind regards
> Torsten
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TOMAHAWK-542) forceId does not work on dataTable
Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TOMAHAWK-542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leonardo Uribe updated TOMAHAWK-542:
------------------------------------
Resolution: Fixed
Fix Version/s: 1.1.7-SNAPSHOT
Assignee: Leonardo Uribe
Status: Resolved (was: Patch Available)
> forceId does not work on dataTable
> ----------------------------------
>
> Key: TOMAHAWK-542
> URL: https://issues.apache.org/jira/browse/TOMAHAWK-542
> Project: MyFaces Tomahawk
> Issue Type: Bug
> Components: Extended Datatable
> Affects Versions: 1.1.3
> Environment: tomcat 5.5, java 1.5
> Reporter: Torsten Krah
> Assignee: Leonardo Uribe
> Priority: Minor
> Fix For: 1.1.7-SNAPSHOT
>
> Attachments: HtmlDataList.java, HtmlDataTableHack.java
>
>
> Using forceId="true" with a extended dataTable still gives me the
> generated one - the id gets not forced in the generated output.
> t:panelGroup e.g. with forceId works.
> According to the docs ( http://myfaces.apache.org/tomahawk/forceId.html ) it should work with all t: components.
> kind regards
> Torsten
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TOMAHAWK-542) forceId does not work on dataTable
Posted by "Torsten Krah (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TOMAHAWK-542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12498134 ]
Torsten Krah commented on TOMAHAWK-542:
---------------------------------------
Thx for help.
Can you mabye attach a unified diff file against current trunk instead of the complete class file?
> forceId does not work on dataTable
> ----------------------------------
>
> Key: TOMAHAWK-542
> URL: https://issues.apache.org/jira/browse/TOMAHAWK-542
> Project: MyFaces Tomahawk
> Issue Type: Bug
> Components: Extended Datatable
> Affects Versions: 1.1.3
> Environment: tomcat 5.5, java 1.5
> Reporter: Torsten Krah
> Priority: Minor
> Attachments: HtmlDataList.java, HtmlDataTableHack.java
>
>
> Using forceId="true" with a extended dataTable still gives me the
> generated one - the id gets not forced in the generated output.
> t:panelGroup e.g. with forceId works.
> According to the docs ( http://myfaces.apache.org/tomahawk/forceId.html ) it should work with all t: components.
> kind regards
> Torsten
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TOMAHAWK-542) forceId does not work on dataTable
Posted by "Marco Grimm (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TOMAHAWK-542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marco Grimm updated TOMAHAWK-542:
---------------------------------
Status: Patch Available (was: Open)
> forceId does not work on dataTable
> ----------------------------------
>
> Key: TOMAHAWK-542
> URL: https://issues.apache.org/jira/browse/TOMAHAWK-542
> Project: MyFaces Tomahawk
> Issue Type: Bug
> Components: Extended Datatable
> Affects Versions: 1.1.3
> Environment: tomcat 5.5, java 1.5
> Reporter: Torsten Krah
> Priority: Minor
>
> Using forceId="true" with a extended dataTable still gives me the
> generated one - the id gets not forced in the generated output.
> t:panelGroup e.g. with forceId works.
> According to the docs ( http://myfaces.apache.org/tomahawk/forceId.html ) it should work with all t: components.
> kind regards
> Torsten
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.