You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/01/13 09:57:24 UTC
[GitHub] [incubator-nuttx-apps] cwespressif opened a new pull request #557: system/argtable3: Add argtable3 patch to fix compilation errors and warnings
cwespressif opened a new pull request #557:
URL: https://github.com/apache/incubator-nuttx-apps/pull/557
## Summary
Add argtable3 patch to fix compilation errors and warnings in NuttX.
## Impact
Only when the iperf example is enabled.
## Testing
By compiling NuttX-app: system/argtable3, the errors and warnings are disappeared.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] cwespressif commented on pull request #557: system/argtable3: Add argtable3 patch to fix compilation errors and warnings
Posted by GitBox <gi...@apache.org>.
cwespressif commented on pull request #557:
URL: https://github.com/apache/incubator-nuttx-apps/pull/557#issuecomment-759934049
> @cwespressif
> My approach is almost the same as you but I noticed that I added CONFIG_NET_TCP_WRITE_BUFFERS=y locally.
> If I remove the setting, it works now.
>
> Also, #559 now works.
> I think we should discard this PR and take #559. What do you think?
Agree, I am closing it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] cwespressif commented on pull request #557: system/argtable3: Add argtable3 patch to fix compilation errors and warnings
Posted by GitBox <gi...@apache.org>.
cwespressif commented on pull request #557:
URL: https://github.com/apache/incubator-nuttx-apps/pull/557#issuecomment-759889713
> @cwespressif
>
> I tried this PR with esp32-devkitc but it seems that it's unstable.
>
> ```
> nsh> uname -a
> NuttX 10.0.1 657088318a-dirty Jan 14 2021 09:33:40 xtensa esp32-devkitc
> nsh> ifconfig
> wlan0 Link encap:Ethernet HWaddr 3c:71:bf:8a:dd:10 at UP
> inet addr:192.168.10.6 DRaddr:192.168.10.1 Mask:255.255.255.0
>
> nsh> iperf -c 192.168.10.16
> IP: 192.168.10.6
>
> mode=tcp-client sip=192.168.10.6:5001, dip=192.168.10.16:5001, interval=3, time=30
> W (43841) wifi:<ba-add>idx:0 (ifx:0, fe:b7:97:5a:a3:8a), tid:6, ssn:2, winSize:64
> W (45628) wifi:<ba-add>idx:1 (ifx:0, fe:b7:97:5a:a3:8a), tid:0, ssn:0, winSize:64
>
> Interval Bandwidth
>
> 0- 3 sec, 0.48 Mbits/sec
> 3- 6 sec, 0.00 Mbits/sec
> 6- 9 sec, 0.00 Mbits/sec
> 9- 12 sec, 0.00 Mbits/sec
> 12- 15 sec, 0.00 Mbits/sec
> 15- 18 sec, 0.00 Mbits/sec
> 18- 21 sec, 0.00 Mbits/sec
> 21- 24 sec, 0.00 Mbits/sec
> 24- 27 sec, 0.00 Mbits/sec
> 27- 30 sec, 0.00 Mbits/sec
> ```
Hi @masayuki2009 I use the incubator-nuttx master version to test with this PR, the config is wapi which under esp32-devkitc, enable iperf example, the test result seems OK and stable, but your test looks like the device has stopped sending packets,could you provide a wireless packet capture?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] cwespressif closed pull request #557: system/argtable3: Add argtable3 patch to fix compilation errors and warnings
Posted by GitBox <gi...@apache.org>.
cwespressif closed pull request #557:
URL: https://github.com/apache/incubator-nuttx-apps/pull/557
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] cwespressif edited a comment on pull request #557: system/argtable3: Add argtable3 patch to fix compilation errors and warnings
Posted by GitBox <gi...@apache.org>.
cwespressif edited a comment on pull request #557:
URL: https://github.com/apache/incubator-nuttx-apps/pull/557#issuecomment-759889713
> @cwespressif
>
> I tried this PR with esp32-devkitc but it seems that it's unstable.
>
> ```
> nsh> uname -a
> NuttX 10.0.1 657088318a-dirty Jan 14 2021 09:33:40 xtensa esp32-devkitc
> nsh> ifconfig
> wlan0 Link encap:Ethernet HWaddr 3c:71:bf:8a:dd:10 at UP
> inet addr:192.168.10.6 DRaddr:192.168.10.1 Mask:255.255.255.0
>
> nsh> iperf -c 192.168.10.16
> IP: 192.168.10.6
>
> mode=tcp-client sip=192.168.10.6:5001, dip=192.168.10.16:5001, interval=3, time=30
> W (43841) wifi:<ba-add>idx:0 (ifx:0, fe:b7:97:5a:a3:8a), tid:6, ssn:2, winSize:64
> W (45628) wifi:<ba-add>idx:1 (ifx:0, fe:b7:97:5a:a3:8a), tid:0, ssn:0, winSize:64
>
> Interval Bandwidth
>
> 0- 3 sec, 0.48 Mbits/sec
> 3- 6 sec, 0.00 Mbits/sec
> 6- 9 sec, 0.00 Mbits/sec
> 9- 12 sec, 0.00 Mbits/sec
> 12- 15 sec, 0.00 Mbits/sec
> 15- 18 sec, 0.00 Mbits/sec
> 18- 21 sec, 0.00 Mbits/sec
> 21- 24 sec, 0.00 Mbits/sec
> 24- 27 sec, 0.00 Mbits/sec
> 27- 30 sec, 0.00 Mbits/sec
> ```
Hi @masayuki2009 I use the incubator-nuttx master version to test with this PR, the config is wapi which under esp32-devkitc, enable iperf example, the test result seems OK and stable, but your test looks like the device has stopped sending packets,could you provide a wireless packet capture?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] cwespressif commented on a change in pull request #557: system/argtable3: Add argtable3 patch to fix compilation errors and warnings
Posted by GitBox <gi...@apache.org>.
cwespressif commented on a change in pull request #557:
URL: https://github.com/apache/incubator-nuttx-apps/pull/557#discussion_r557001970
##########
File path: system/argtable3/argtable3.patch
##########
@@ -0,0 +1,512 @@
+diff -ur argtable3/argtable3.c argtable3-v3.0.0/argtable3.c
+--- argtable3/argtable3.c 2020-12-14 21:55:38.861316071 +0800
++++ argtable3-v3.0.0/argtable3.c 2020-12-14 21:52:37.189316071 +0800
+@@ -72,13 +72,13 @@
+
+ enum
+ {
+- EMINCOUNT = 1,
+- EMAXCOUNT,
+- EBADINT,
+- EOVERFLOW,
+- EBADDOUBLE,
+- EBADDATE,
+- EREGNOMATCH
++ AEMINCOUNT = 1,
Review comment:
The defined enum structure conflicts with the macro definition in other places:
https://github.com/apache/incubator-nuttx/blob/master/include/errno.h#L303
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] masayuki2009 commented on pull request #557: system/argtable3: Add argtable3 patch to fix compilation errors and warnings
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #557:
URL: https://github.com/apache/incubator-nuttx-apps/pull/557#issuecomment-759848155
@cwespressif
I tried this PR with esp32-devkitc but it seems that it's unstable.
```
nsh> uname -a
NuttX 10.0.1 657088318a-dirty Jan 14 2021 09:33:40 xtensa esp32-devkitc
nsh> ifconfig
wlan0 Link encap:Ethernet HWaddr 3c:71:bf:8a:dd:10 at UP
inet addr:192.168.10.6 DRaddr:192.168.10.1 Mask:255.255.255.0
nsh> iperf -c 192.168.10.16
IP: 192.168.10.6
mode=tcp-client sip=192.168.10.6:5001, dip=192.168.10.16:5001, interval=3, time=30
W (43841) wifi:<ba-add>idx:0 (ifx:0, fe:b7:97:5a:a3:8a), tid:6, ssn:2, winSize:64
W (45628) wifi:<ba-add>idx:1 (ifx:0, fe:b7:97:5a:a3:8a), tid:0, ssn:0, winSize:64
Interval Bandwidth
0- 3 sec, 0.48 Mbits/sec
3- 6 sec, 0.00 Mbits/sec
6- 9 sec, 0.00 Mbits/sec
9- 12 sec, 0.00 Mbits/sec
12- 15 sec, 0.00 Mbits/sec
15- 18 sec, 0.00 Mbits/sec
18- 21 sec, 0.00 Mbits/sec
21- 24 sec, 0.00 Mbits/sec
24- 27 sec, 0.00 Mbits/sec
27- 30 sec, 0.00 Mbits/sec
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] cwespressif edited a comment on pull request #557: system/argtable3: Add argtable3 patch to fix compilation errors and warnings
Posted by GitBox <gi...@apache.org>.
cwespressif edited a comment on pull request #557:
URL: https://github.com/apache/incubator-nuttx-apps/pull/557#issuecomment-759889713
> @cwespressif
>
> I tried this PR with esp32-devkitc but it seems that it's unstable.
>
> ```
> nsh> uname -a
> NuttX 10.0.1 657088318a-dirty Jan 14 2021 09:33:40 xtensa esp32-devkitc
> nsh> ifconfig
> wlan0 Link encap:Ethernet HWaddr 3c:71:bf:8a:dd:10 at UP
> inet addr:192.168.10.6 DRaddr:192.168.10.1 Mask:255.255.255.0
>
> nsh> iperf -c 192.168.10.16
> IP: 192.168.10.6
>
> mode=tcp-client sip=192.168.10.6:5001, dip=192.168.10.16:5001, interval=3, time=30
> W (43841) wifi:<ba-add>idx:0 (ifx:0, fe:b7:97:5a:a3:8a), tid:6, ssn:2, winSize:64
> W (45628) wifi:<ba-add>idx:1 (ifx:0, fe:b7:97:5a:a3:8a), tid:0, ssn:0, winSize:64
>
> Interval Bandwidth
>
> 0- 3 sec, 0.48 Mbits/sec
> 3- 6 sec, 0.00 Mbits/sec
> 6- 9 sec, 0.00 Mbits/sec
> 9- 12 sec, 0.00 Mbits/sec
> 12- 15 sec, 0.00 Mbits/sec
> 15- 18 sec, 0.00 Mbits/sec
> 18- 21 sec, 0.00 Mbits/sec
> 21- 24 sec, 0.00 Mbits/sec
> 24- 27 sec, 0.00 Mbits/sec
> 27- 30 sec, 0.00 Mbits/sec
> ```
Hi @masayuki2009 I use the incubator-nuttx master version to test with this PR, the config is wapi which under esp32-devkitc, enable iperf example, the test result seems OK and stable, but your test looks like the device has stopped sending packets,could you provide a wireless packet capture?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] masayuki2009 commented on pull request #557: system/argtable3: Add argtable3 patch to fix compilation errors and warnings
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #557:
URL: https://github.com/apache/incubator-nuttx-apps/pull/557#issuecomment-759931712
@cwespressif
My approach is almost the same as you but I noticed that I added CONFIG_NET_TCP_WRITE_BUFFERS=y locally.
If I remove the setting, it works now.
Also, https://github.com/apache/incubator-nuttx-apps/pull/559 now works.
I think we should discard this PR and take #559. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #557: system/argtable3: Add argtable3 patch to fix compilation errors and warnings
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #557:
URL: https://github.com/apache/incubator-nuttx-apps/pull/557#issuecomment-759635818
@cwespressif and @masayuki2009 the latest offical release don't need apply the patch anymore, please try https://github.com/apache/incubator-nuttx-apps/pull/559
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #557: system/argtable3: Add argtable3 patch to fix compilation errors and warnings
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #557:
URL: https://github.com/apache/incubator-nuttx-apps/pull/557#discussion_r556552247
##########
File path: system/argtable3/argtable3.patch
##########
@@ -0,0 +1,512 @@
+diff -ur argtable3/argtable3.c argtable3-v3.0.0/argtable3.c
+--- argtable3/argtable3.c 2020-12-14 21:55:38.861316071 +0800
++++ argtable3-v3.0.0/argtable3.c 2020-12-14 21:52:37.189316071 +0800
+@@ -72,13 +72,13 @@
+
+ enum
+ {
+- EMINCOUNT = 1,
+- EMAXCOUNT,
+- EBADINT,
+- EOVERFLOW,
+- EBADDOUBLE,
+- EBADDATE,
+- EREGNOMATCH
++ AEMINCOUNT = 1,
Review comment:
Why need rename the error number?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org