[GitHub] [geode] demery-pivotal opened a new pull request #5493: GEODE-8404: Simplify AvailablePortHelper

[GitBox <gi...@apache.org>]

demery-pivotal opened a new pull request #5493:
URL: https://github.com/apache/geode/pull/5493


   Removed the following unused methods:
   - getRandomAvailableTCPPortRange(int)
   - getRandomAvailableTCPPorts(int,bool)
   - getRandomAvailableTCPPortRangeKeepers(int)
   - getRandomAvailableTCPPortRangeKeepers(int,bool)
   
   Removed two methods that used an ineffective, incorrect calculation to
   try to distribute ports evenly across VMs:
   
   - getRandomAvailablePortForDUnitSite()
   - getRandomAvailableTCPPortsForDUnitSite()
   
   These methods attempted to distribute ports by using the VM id as a
   modulus. The intention was something like this (assuming 5 VMs):
   
   VM 1 would get ports 20001, 20006, 20011, 20016, ...
   VM 2 would get ports 20002, 20007, 20012, 20017, ...
   VM 3 would get ports 20003, 20008, 20013, 20018, ...
   VM 4 would get ports 20004, 20009, 20014, 20019, ...
   VM 5 would get ports 20000, 20005, 20010, 20015, ...
   
   But the actual calculation distributed ports like this:
   
   VM 1: 20000, 20001, 20002, 20003, 20004, ...
   VM 2: 20000, 20002, 20004, 20006, 20008, ...
   VM 3: 20001, 20004, 20007, 20010, 20013, ...
   VM 4: 20000, 20004, 20008, 20012, 20016, ...
   VM 5: 20000, 20005, 20010, 20015, 20020, ...
   
   ... with lots of potential port collisions from one VM to another.
   
   The few uses of these methods were replaced by calls to existing methods
   getRandomAvailableTCPPort() and getRandomAvailableTCPPorts(), which
   offer a more reliable method of distributing ports.
   
   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   - [ ] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, check Concourse for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to dev@geode.apache.org.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] demery-pivotal merged pull request #5493: GEODE-8404: Simplify AvailablePortHelper

[GitBox <gi...@apache.org>]

demery-pivotal merged pull request #5493:
URL: https://github.com/apache/geode/pull/5493


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org