You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by revans2 <gi...@git.apache.org> on 2018/01/04 21:30:41 UTC

[GitHub] storm issue #2241: STORM-2306 : Messaging subsystem redesign.

Github user revans2 commented on the issue:

    https://github.com/apache/storm/pull/2241
  
    Sorry it has taken me so long to get back to this.  I did a quick pass through the code, but I need to spend some time to go more in depth.  I expect to be doing this this afternoon and tomorrow.
    
    My biggest concern right now is around up-merging and getting the unit tests to pass.  I don't see a reason to have JCQueueTest fail 100% of the time.
    
    I am also concerned that a lot of other unit tests fail 100% of the time with this patch too.


---