[GitHub] [flink] GJL commented on a change in pull request #11056: [FLINK-15903][e2e] Make REST port configurable

[GitBox <gi...@apache.org>]

GJL commented on a change in pull request #11056:
URL: https://github.com/apache/flink/pull/11056#discussion_r422953900



##########
File path: flink-end-to-end-tests/test-scripts/common.sh
##########
@@ -263,16 +264,18 @@ function wait_rest_endpoint_up {
     echo "Waiting for ${endpoint_name} REST endpoint to come up..."
     sleep 1
   done
-  echo "${endpoint_name} REST endpoint has not started within a timeout of ${TIMEOUT} sec"
+  echo "${endpoint_name} REST endpoint has not started on query url '${query_url}' within a timeout of ${TIMEOUT} sec"
   exit 1
 }
 
 function wait_dispatcher_running {
-  local query_url="${REST_PROTOCOL}://${NODENAME}:8081/taskmanagers"
+  local query_url="${REST_PROTOCOL}://${NODENAME}:${NODEPORT}/taskmanagers"
   wait_rest_endpoint_up "${query_url}" "Dispatcher" "\{\"taskmanagers\":\[.+\]\}"
 }
 
 function start_cluster {
+  echo "# Configuration appended by common.sh script for e2e tests" >> ${FLINK_DIR}/conf/flink-conf.yaml
+  echo "rest.port: ${NODEPORT}" >> ${FLINK_DIR}/conf/flink-conf.yaml

Review comment:
       We cannot use `set_config_key rest.port ...` ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org