You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/03/05 15:26:29 UTC
[GitHub] [rocketmq] zhangjidi2016 opened a new pull request #1824: [ISSUE
#1770]Add a query message trace command in mqadmin.
zhangjidi2016 opened a new pull request #1824: [ISSUE #1770]Add a query message trace command in mqadmin.
URL: https://github.com/apache/rocketmq/pull/1824
## What is the purpose of the change
Add a query message trace command in mqadmin.
## Brief changelog
Add a query message trace command in mqadmin.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] coveralls edited a comment on issue #1824: [ISSUE
#1770]Add a query message trace command in mqadmin.
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #1824: [ISSUE #1770]Add a query message trace command in mqadmin.
URL: https://github.com/apache/rocketmq/pull/1824#issuecomment-595327899
[](https://coveralls.io/builds/29169350)
Coverage increased (+0.1%) to 51.05% when pulling **5324ffd3229533d9e80bff7a787ce26ced1196af on zhangjidi2016:add_query_trace_command** into **3974677f04815609951c17059d85d3795eb51247 on apache:develop**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] zhangjidi2016 commented on issue #1824: [ISSUE #1770]Add
a query message trace command in mqadmin.
Posted by GitBox <gi...@apache.org>.
zhangjidi2016 commented on issue #1824: [ISSUE #1770]Add a query message trace command in mqadmin.
URL: https://github.com/apache/rocketmq/pull/1824#issuecomment-595594819
The command result in console，@zongtanghu @duhenglucky ，please help to review it，thanks！
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] coveralls commented on issue #1824: [ISSUE #1770]Add a
query message trace command in mqadmin.
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #1824: [ISSUE #1770]Add a query message trace command in mqadmin.
URL: https://github.com/apache/rocketmq/pull/1824#issuecomment-595327899
[](https://coveralls.io/builds/29156175)
Coverage decreased (-0.09%) to 50.829% when pulling **4fca91fa6f3c91ba0b6c8f13f4fdfcfffb2401d7 on zhangjidi2016:add_query_trace_command** into **3974677f04815609951c17059d85d3795eb51247 on apache:develop**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] zongtanghu commented on a change in pull request #1824:
[ISSUE #1770] Add a query message trace command in mqadmin.
Posted by GitBox <gi...@apache.org>.
zongtanghu commented on a change in pull request #1824: [ISSUE #1770] Add a query message trace command in mqadmin.
URL: https://github.com/apache/rocketmq/pull/1824#discussion_r399054856
##########
File path: client/src/main/java/org/apache/rocketmq/client/trace/TraceDataEncoder.java
##########
@@ -52,15 +52,16 @@
bean.setTags(line[6]);
bean.setKeys(line[7]);
bean.setStoreHost(line[8]);
- bean.setBodyLength(Integer.parseInt(line[9]));
- pubContext.setCostTime(Integer.parseInt(line[10]));
- bean.setMsgType(MessageType.values()[Integer.parseInt(line[11])]);
+ bean.setClientHost(line[9]);
+ bean.setBodyLength(Integer.parseInt(line[10]));
+ pubContext.setCostTime(Integer.parseInt(line[11]));
+ bean.setMsgType(MessageType.values()[Integer.parseInt(line[12])]);
- if (line.length == 13) {
- pubContext.setSuccess(Boolean.parseBoolean(line[12]));
- } else if (line.length == 14) {
- bean.setOffsetMsgId(line[12]);
+ if (line.length == 14) {
pubContext.setSuccess(Boolean.parseBoolean(line[13]));
+ } else if (line.length == 15) {
+ bean.setOffsetMsgId(line[13]);
+ pubContext.setSuccess(Boolean.parseBoolean(line[14]));
Review comment:
Here, you must think of a critical compatibility problem that users depend on the older version of rocketmq client ,such as 4.4.0 or 4.5.0, then it send older format's message trace data, so you can add this command can't resolve this problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services