[GitHub] [flink] tillrohrmann commented on a change in pull request #16261: [FLINK-23045][tests] Harden RunnablesTest by not relying on timeout

[GitBox <gi...@apache.org>]

tillrohrmann commented on a change in pull request #16261:
URL: https://github.com/apache/flink/pull/16261#discussion_r657975230



##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/util/RunnablesTest.java
##########
@@ -53,9 +55,9 @@ public void testExecutorService_uncaughtExceptionHandler() throws InterruptedExc
                 () -> {
                     throw new RuntimeException("foo");
                 });
-        Assert.assertTrue(
-                "Expected handler to be called.",
-                handlerCalled.await(TIMEOUT_MS, TimeUnit.MILLISECONDS));
+
+        // expect handler to be called
+        handlerCalled.await();

Review comment:
       Because there we test that we don't call the uncaught exception handler. Hence, we need the timeout.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org