You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/12 07:07:37 UTC
[GitHub] [spark] HyukjinKwon commented on a change in pull request #28556: [SPARK-31736][SQL] Nested column aliasing for RepartitionByExpression/Join
HyukjinKwon commented on a change in pull request #28556:
URL: https://github.com/apache/spark/pull/28556#discussion_r439245169
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasing.scala
##########
@@ -34,7 +34,8 @@ object NestedColumnAliasing {
: Option[(Map[ExtractValue, Alias], Map[ExprId, Seq[Alias]])] = plan match {
case Project(projectList, child)
if SQLConf.get.nestedSchemaPruningEnabled && canProjectPushThrough(child) =>
- getAliasSubMap(projectList)
+ val exprCandidatesToPrune = projectList ++ child.expressions
+ getAliasSubMap(exprCandidatesToPrune, child.producedAttributes.toSeq)
case plan if SQLConf.get.nestedSchemaPruningEnabled && canPruneOn(plan) =>
Review comment:
No big deal but I would rename `plan` to `p` to avoid shadowing the `plan` var. At least my IDE complains on that.
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasing.scala
##########
@@ -34,7 +34,8 @@ object NestedColumnAliasing {
: Option[(Map[ExtractValue, Alias], Map[ExprId, Seq[Alias]])] = plan match {
case Project(projectList, child)
if SQLConf.get.nestedSchemaPruningEnabled && canProjectPushThrough(child) =>
- getAliasSubMap(projectList)
+ val exprCandidatesToPrune = projectList ++ child.expressions
+ getAliasSubMap(exprCandidatesToPrune, child.producedAttributes.toSeq)
case plan if SQLConf.get.nestedSchemaPruningEnabled && canPruneOn(plan) =>
Review comment:
No big deal but I would rename `plan` to `p` to avoid shadowing the `plan` argument. At least my IDE complains on that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org