You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@rocketmq.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/03/27 06:12:41 UTC

[jira] [Commented] (ROCKETMQ-104) Make MQAdmin commands throw exceptions

    [ https://issues.apache.org/jira/browse/ROCKETMQ-104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15942700#comment-15942700 ] 

ASF GitHub Bot commented on ROCKETMQ-104:
-----------------------------------------

Github user vongosling commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/65
  
    @shroman Could you help to close this PR and Jira issue:-)


> Make MQAdmin commands throw exceptions
> --------------------------------------
>
>                 Key: ROCKETMQ-104
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-104
>             Project: Apache RocketMQ
>          Issue Type: Improvement
>            Reporter: Roman Shtykh
>            Assignee: Roman Shtykh
>
> *Why to throw exceptions?*
> With the current implementation you don't know if the command fails unless you look at console. This is one reason why errors in unit tests like in ROCKETMQ-77 can go unnoticed.
> If stack tracing is still needed, we can add logging when throwing exceptions.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)