You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/04/26 03:14:10 UTC
[GitHub] [spark] HyukjinKwon commented on a change in pull request #24335:
[SPARK-27425] Add count_if functions
HyukjinKwon commented on a change in pull request #24335: [SPARK-27425] Add count_if functions
URL: https://github.com/apache/spark/pull/24335#discussion_r278796718
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CountIf.scala
##########
@@ -0,0 +1,73 @@
+/*
Review comment:
I didn't suggest but I asked if there are multiple stuff like `sum_of`, `avg_if`.
It's a different to add one function vs a set of multiple functions. If it needs a bunch of huge codes to add those multiple functions, it's a different story, than adding a single function to match.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org