You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Mike Pfaff (JIRA)" <ji...@apache.org> on 2008/08/20 18:22:46 UTC

[jira] Created: (SLING-624) ignoreImportProviders cannot have more than one value

ignoreImportProviders cannot have more than one value
-----------------------------------------------------

                 Key: SLING-624
                 URL: https://issues.apache.org/jira/browse/SLING-624
             Project: Sling
          Issue Type: Bug
          Components: Maven Plugins
            Reporter: Mike Pfaff


When using the following initial content configuration for the maven-bundle-plugin, only json files are ignored, but xml files are evaluated. The underlying problem is that ignoreImportProviders (which is part of a single Sling-Initial-Content entry) expects a comma-separated list and the Sling-Initial-Content expects a comma-separated list of entries.

<Sling-Initial-Content>
CQ-INF/content/apps/xyz/docroot;overwrite:=true;path:=/apps/xyz/docroot;ignoreImportProviders:=json,xml,
CQ-INF/content/apps/xyz/components;overwrite:=true;path:=/apps/xyz/components,
CQ-INF/content/apps/xyz/templates;overwrite:=true;path:=/apps/xyz/templates
</Sling-Initial-Content>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Re: [jira] Created: (SLING-624) ignoreImportProviders cannot have more than one value

Posted by Carsten Ziegeler <cz...@apache.org>.
Felix Meschberger wrote:
> 
> I fear using a different separator would really cause confusion, because
>  we are building a ManifestHeader, which adheres to the general OSGi
> header syntax. This syntax IIRC copes with the problem of attribute and
> directive values containing certain characters in such a way, that these
> values must be quoted.
> 
> See Section 3.2.3 Common Header Syntax and 1.3.2 General Syntax
> Definitions, in particular the directive and argument productions of the
> latter.
> 
Yes, you're right - I just looked at the code and it should properly
handle the quotes. So this is the way to go.

Thanks
Carsten

-- 
Carsten Ziegeler
cziegeler@apache.org

Re: [jira] Created: (SLING-624) ignoreImportProviders cannot have more than one value

Posted by Felix Meschberger <fm...@gmail.com>.
Hi,

Carsten Ziegeler schrieb:
> Felix Meschberger wrote:
> 
>> The comma is used to separate entries in the list of provided content.
>> So this entry provides the CQ-INF/...xyz/docroot ignoring JSON and "xml"
>>  with default setup.
>>
>> Have your tried putting the "json,xml" in double quotes, like this ?
>>    CQ-INF/...xyz/docroot;....;ignoreImportProviders:="json,xml",
>>
> Ah, this might work - I thought about using a different separator character
> like "|" or something. This should reduce the confusion/problems when
> this feature is used.

I fear using a different separator would really cause confusion, because 
  we are building a ManifestHeader, which adheres to the general OSGi 
header syntax. This syntax IIRC copes with the problem of attribute and 
directive values containing certain characters in such a way, that these 
values must be quoted.

See Section 3.2.3 Common Header Syntax and 1.3.2 General Syntax 
Definitions, in particular the directive and argument productions of the 
latter.

Regards
Felix

Re: [jira] Created: (SLING-624) ignoreImportProviders cannot have more than one value

Posted by Carsten Ziegeler <cz...@apache.org>.
Felix Meschberger wrote:

> 
> The comma is used to separate entries in the list of provided content.
> So this entry provides the CQ-INF/...xyz/docroot ignoring JSON and "xml"
>  with default setup.
> 
> Have your tried putting the "json,xml" in double quotes, like this ?
>    CQ-INF/...xyz/docroot;....;ignoreImportProviders:="json,xml",
> 
Ah, this might work - I thought about using a different separator character
like "|" or something. This should reduce the confusion/problems when
this feature is used.


Carsten
-- 
Carsten Ziegeler
cziegeler@apache.org

Re: [jira] Created: (SLING-624) ignoreImportProviders cannot have more than one value

Posted by Felix Meschberger <fm...@gmail.com>.
Hi,

Mike Pfaff (JIRA) schrieb:
>                  URL: https://issues.apache.org/jira/browse/SLING-624
> When using the following initial content configuration for the maven-bundle-plugin, only json files are ignored, but xml files are evaluated. The underlying problem is that ignoreImportProviders (which is part of a single Sling-Initial-Content entry) expects a comma-separated list and the Sling-Initial-Content expects a comma-separated list of entries.
> 
> <Sling-Initial-Content>
> CQ-INF/content/apps/xyz/docroot;overwrite:=true;path:=/apps/xyz/docroot;ignoreImportProviders:=json,xml,

The comma is used to separate entries in the list of provided content. 
So this entry provides the CQ-INF/...xyz/docroot ignoring JSON and "xml" 
  with default setup.

Have your tried putting the "json,xml" in double quotes, like this ?
    CQ-INF/...xyz/docroot;....;ignoreImportProviders:="json,xml",

Regards
Felix

> CQ-INF/content/apps/xyz/components;overwrite:=true;path:=/apps/xyz/components,
> CQ-INF/content/apps/xyz/templates;overwrite:=true;path:=/apps/xyz/templates
> </Sling-Initial-Content>
> 

[jira] Commented: (SLING-624) ignoreImportProviders cannot have more than one value

Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SLING-624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625688#action_12625688 ] 

Carsten Ziegeler commented on SLING-624:
----------------------------------------

Hi Mike,

can you add the whole Sling-Initial-Content config you used here? And what exactly happended?

> ignoreImportProviders cannot have more than one value
> -----------------------------------------------------
>
>                 Key: SLING-624
>                 URL: https://issues.apache.org/jira/browse/SLING-624
>             Project: Sling
>          Issue Type: Bug
>          Components: JCR Contentloader
>    Affects Versions: JCR Contentloader 2.0.4
>            Reporter: Mike Pfaff
>            Assignee: Carsten Ziegeler
>             Fix For: JCR Contentloader 2.0.4
>
>
> When using the following initial content configuration for the maven-bundle-plugin, only json files are ignored, but xml files are evaluated. The underlying problem is that ignoreImportProviders (which is part of a single Sling-Initial-Content entry) expects a comma-separated list and the Sling-Initial-Content expects a comma-separated list of entries.
> <Sling-Initial-Content>
> CQ-INF/content/apps/xyz/docroot;overwrite:=true;path:=/apps/xyz/docroot;ignoreImportProviders:=json,xml,
> CQ-INF/content/apps/xyz/components;overwrite:=true;path:=/apps/xyz/components,
> CQ-INF/content/apps/xyz/templates;overwrite:=true;path:=/apps/xyz/templates
> </Sling-Initial-Content>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SLING-624) ignoreImportProviders cannot have more than one value

Posted by "Mike Pfaff (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SLING-624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12624045#action_12624045 ] 

Mike Pfaff commented on SLING-624:
----------------------------------

Workaround: Put the whole tree, for which you do not want the xml/json auto-import, into a zip. The importer will then automatically extract the zip contents, but he will leave the json and xml files alone.

> ignoreImportProviders cannot have more than one value
> -----------------------------------------------------
>
>                 Key: SLING-624
>                 URL: https://issues.apache.org/jira/browse/SLING-624
>             Project: Sling
>          Issue Type: Bug
>          Components: JCR Contentloader
>    Affects Versions: JCR Contentloader 2.0.4
>            Reporter: Mike Pfaff
>            Assignee: Carsten Ziegeler
>             Fix For: JCR Contentloader 2.0.4
>
>
> When using the following initial content configuration for the maven-bundle-plugin, only json files are ignored, but xml files are evaluated. The underlying problem is that ignoreImportProviders (which is part of a single Sling-Initial-Content entry) expects a comma-separated list and the Sling-Initial-Content expects a comma-separated list of entries.
> <Sling-Initial-Content>
> CQ-INF/content/apps/xyz/docroot;overwrite:=true;path:=/apps/xyz/docroot;ignoreImportProviders:=json,xml,
> CQ-INF/content/apps/xyz/components;overwrite:=true;path:=/apps/xyz/components,
> CQ-INF/content/apps/xyz/templates;overwrite:=true;path:=/apps/xyz/templates
> </Sling-Initial-Content>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SLING-624) ignoreImportProviders cannot have more than one value

Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SLING-624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carsten Ziegeler updated SLING-624:
-----------------------------------

          Component/s:     (was: Maven Plugins)
                       JCR Contentloader
    Affects Version/s: JCR Contentloader 2.0.4
        Fix Version/s: JCR Contentloader 2.0.4
             Assignee: Carsten Ziegeler

> ignoreImportProviders cannot have more than one value
> -----------------------------------------------------
>
>                 Key: SLING-624
>                 URL: https://issues.apache.org/jira/browse/SLING-624
>             Project: Sling
>          Issue Type: Bug
>          Components: JCR Contentloader
>    Affects Versions: JCR Contentloader 2.0.4
>            Reporter: Mike Pfaff
>            Assignee: Carsten Ziegeler
>             Fix For: JCR Contentloader 2.0.4
>
>
> When using the following initial content configuration for the maven-bundle-plugin, only json files are ignored, but xml files are evaluated. The underlying problem is that ignoreImportProviders (which is part of a single Sling-Initial-Content entry) expects a comma-separated list and the Sling-Initial-Content expects a comma-separated list of entries.
> <Sling-Initial-Content>
> CQ-INF/content/apps/xyz/docroot;overwrite:=true;path:=/apps/xyz/docroot;ignoreImportProviders:=json,xml,
> CQ-INF/content/apps/xyz/components;overwrite:=true;path:=/apps/xyz/components,
> CQ-INF/content/apps/xyz/templates;overwrite:=true;path:=/apps/xyz/templates
> </Sling-Initial-Content>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SLING-624) ignoreImportProviders cannot have more than one value

Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SLING-624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12624587#action_12624587 ] 

Carsten Ziegeler commented on SLING-624:
----------------------------------------

Hi Mike,

could you please test if quoting the value works? 

CQ-INF/content/apps/xyz/docroot;overwrite:=true;path:=/apps/xyz/docroot;ignoreImportProviders:="json,xml", 

> ignoreImportProviders cannot have more than one value
> -----------------------------------------------------
>
>                 Key: SLING-624
>                 URL: https://issues.apache.org/jira/browse/SLING-624
>             Project: Sling
>          Issue Type: Bug
>          Components: JCR Contentloader
>    Affects Versions: JCR Contentloader 2.0.4
>            Reporter: Mike Pfaff
>            Assignee: Carsten Ziegeler
>             Fix For: JCR Contentloader 2.0.4
>
>
> When using the following initial content configuration for the maven-bundle-plugin, only json files are ignored, but xml files are evaluated. The underlying problem is that ignoreImportProviders (which is part of a single Sling-Initial-Content entry) expects a comma-separated list and the Sling-Initial-Content expects a comma-separated list of entries.
> <Sling-Initial-Content>
> CQ-INF/content/apps/xyz/docroot;overwrite:=true;path:=/apps/xyz/docroot;ignoreImportProviders:=json,xml,
> CQ-INF/content/apps/xyz/components;overwrite:=true;path:=/apps/xyz/components,
> CQ-INF/content/apps/xyz/templates;overwrite:=true;path:=/apps/xyz/templates
> </Sling-Initial-Content>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SLING-624) ignoreImportProviders cannot have more than one value

Posted by "Mike Pfaff (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SLING-624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625682#action_12625682 ] 

Mike Pfaff commented on SLING-624:
----------------------------------

I also tried that, but unfortunately it did not work. IIRC it even "confused" the importer.

> ignoreImportProviders cannot have more than one value
> -----------------------------------------------------
>
>                 Key: SLING-624
>                 URL: https://issues.apache.org/jira/browse/SLING-624
>             Project: Sling
>          Issue Type: Bug
>          Components: JCR Contentloader
>    Affects Versions: JCR Contentloader 2.0.4
>            Reporter: Mike Pfaff
>            Assignee: Carsten Ziegeler
>             Fix For: JCR Contentloader 2.0.4
>
>
> When using the following initial content configuration for the maven-bundle-plugin, only json files are ignored, but xml files are evaluated. The underlying problem is that ignoreImportProviders (which is part of a single Sling-Initial-Content entry) expects a comma-separated list and the Sling-Initial-Content expects a comma-separated list of entries.
> <Sling-Initial-Content>
> CQ-INF/content/apps/xyz/docroot;overwrite:=true;path:=/apps/xyz/docroot;ignoreImportProviders:=json,xml,
> CQ-INF/content/apps/xyz/components;overwrite:=true;path:=/apps/xyz/components,
> CQ-INF/content/apps/xyz/templates;overwrite:=true;path:=/apps/xyz/templates
> </Sling-Initial-Content>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (SLING-624) ignoreImportProviders cannot have more than one value

Posted by "Mike Pfaff (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SLING-624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mike Pfaff closed SLING-624.
----------------------------

    Resolution: Cannot Reproduce

It now works with the double-quotes, therefore closing this issue.

> ignoreImportProviders cannot have more than one value
> -----------------------------------------------------
>
>                 Key: SLING-624
>                 URL: https://issues.apache.org/jira/browse/SLING-624
>             Project: Sling
>          Issue Type: Bug
>          Components: JCR Contentloader
>    Affects Versions: JCR Contentloader 2.0.4
>            Reporter: Mike Pfaff
>            Assignee: Carsten Ziegeler
>             Fix For: JCR Contentloader 2.0.4
>
>
> When using the following initial content configuration for the maven-bundle-plugin, only json files are ignored, but xml files are evaluated. The underlying problem is that ignoreImportProviders (which is part of a single Sling-Initial-Content entry) expects a comma-separated list and the Sling-Initial-Content expects a comma-separated list of entries.
> <Sling-Initial-Content>
> CQ-INF/content/apps/xyz/docroot;overwrite:=true;path:=/apps/xyz/docroot;ignoreImportProviders:=json,xml,
> CQ-INF/content/apps/xyz/components;overwrite:=true;path:=/apps/xyz/components,
> CQ-INF/content/apps/xyz/templates;overwrite:=true;path:=/apps/xyz/templates
> </Sling-Initial-Content>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.