You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2022/06/16 14:01:51 UTC
[GitHub] [logging-log4j2] PashaTurok opened a new pull request, #935: LOG4J2-3537 Fixes problem with wrong ANSI escape code for bright colors
PashaTurok opened a new pull request, #935:
URL: https://github.com/apache/logging-log4j2/pull/935
Here it is. Please, check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] PashaTurok commented on a diff in pull request #935: LOG4J2-3537 Fixes problem with wrong ANSI escape code for bright colors
Posted by GitBox <gi...@apache.org>.
PashaTurok commented on code in PR #935:
URL: https://github.com/apache/logging-log4j2/pull/935#discussion_r899961989
##########
src/site/xdoc/manual/layouts.xml.vm:
##########
@@ -1332,10 +1332,19 @@ WARN [main]: Message 2</pre>
<p>You can override the default colors in the optional {style} option. For example:
#if ($isPDF)
<pre>%highlight{%d [%t] %-5level: %msg%n%throwable}
- {FATAL=white, ERROR=red, WARN=blue, INFO=black,
- DEBUG=green, TRACE=blue}</pre>
+ {FATAL=white, ERROR=red, WARN=bright_blue, INFO=black,
+ DEBUG=bright_green, TRACE=blue}</pre>
#else
- <pre>%highlight{%d [%t] %-5level: %msg%n%throwable}{FATAL=white, ERROR=red, WARN=blue, INFO=black, DEBUG=green, TRACE=blue}</pre>
+ <pre>%highlight{%d [%t] %-5level: %msg%n%throwable}{FATAL=white, ERROR=red, WARN=bright_blue, INFO=black, DEBUG=bright_green, TRACE=blue}</pre>
+ #end
+ </p>
+ <p>At the same time it is possible to use true colors (24 bit). For example:
+ #if ($isPDF)
+ <pre>%highlight{%d [%t] %-5level: %msg%n%throwable}
+ {FATAL=white, ERROR=red, WARN=bg_#5792e6 fg_#eef26b bold, INFO=black,
+ DEBUG=#3fe0a8, TRACE=blue}</pre>
+ #else
+ <pre>%highlight{%d [%t] %-5level: %msg%n%throwable}{FATAL=white, ERROR=red, WARN=bg_#5792e6 fg_#eef26b bold, INFO=black, DEBUG=#3fe0a8, TRACE=blue}</pre>
#end
</p>
Review Comment:
@ppkarwasz I fixed both PRs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] ppkarwasz commented on a diff in pull request #935: LOG4J2-3537 Fixes problem with wrong ANSI escape code for bright colors
Posted by GitBox <gi...@apache.org>.
ppkarwasz commented on code in PR #935:
URL: https://github.com/apache/logging-log4j2/pull/935#discussion_r899929114
##########
src/site/xdoc/manual/layouts.xml.vm:
##########
@@ -1332,10 +1332,19 @@ WARN [main]: Message 2</pre>
<p>You can override the default colors in the optional {style} option. For example:
#if ($isPDF)
<pre>%highlight{%d [%t] %-5level: %msg%n%throwable}
- {FATAL=white, ERROR=red, WARN=blue, INFO=black,
- DEBUG=green, TRACE=blue}</pre>
+ {FATAL=white, ERROR=red, WARN=bright_blue, INFO=black,
+ DEBUG=bright_green, TRACE=blue}</pre>
#else
- <pre>%highlight{%d [%t] %-5level: %msg%n%throwable}{FATAL=white, ERROR=red, WARN=blue, INFO=black, DEBUG=green, TRACE=blue}</pre>
+ <pre>%highlight{%d [%t] %-5level: %msg%n%throwable}{FATAL=white, ERROR=red, WARN=bright_blue, INFO=black, DEBUG=bright_green, TRACE=blue}</pre>
+ #end
+ </p>
+ <p>At the same time it is possible to use true colors (24 bit). For example:
+ #if ($isPDF)
+ <pre>%highlight{%d [%t] %-5level: %msg%n%throwable}
+ {FATAL=white, ERROR=red, WARN=bg_#5792e6 fg_#eef26b bold, INFO=black,
+ DEBUG=#3fe0a8, TRACE=blue}</pre>
+ #else
+ <pre>%highlight{%d [%t] %-5level: %msg%n%throwable}{FATAL=white, ERROR=red, WARN=bg_#5792e6 fg_#eef26b bold, INFO=black, DEBUG=#3fe0a8, TRACE=blue}</pre>
#end
</p>
Review Comment:
This example should be in the PR #933.
##########
src/site/xdoc/manual/layouts.xml.vm:
##########
@@ -1332,10 +1332,19 @@ WARN [main]: Message 2</pre>
<p>You can override the default colors in the optional {style} option. For example:
#if ($isPDF)
<pre>%highlight{%d [%t] %-5level: %msg%n%throwable}
- {FATAL=white, ERROR=red, WARN=blue, INFO=black,
- DEBUG=green, TRACE=blue}</pre>
+ {FATAL=white, ERROR=red, WARN=bright_blue, INFO=black,
+ DEBUG=bright_green, TRACE=blue}</pre>
#else
- <pre>%highlight{%d [%t] %-5level: %msg%n%throwable}{FATAL=white, ERROR=red, WARN=blue, INFO=black, DEBUG=green, TRACE=blue}</pre>
+ <pre>%highlight{%d [%t] %-5level: %msg%n%throwable}{FATAL=white, ERROR=red, WARN=bright_blue, INFO=black, DEBUG=bright_green, TRACE=blue}</pre>
+ #end
+ </p>
+ <p>At the same time it is possible to use true colors (24 bit). For example:
+ #if ($isPDF)
+ <pre>%highlight{%d [%t] %-5level: %msg%n%throwable}
+ {FATAL=white, ERROR=red, WARN=bg_#5792e6 fg_#eef26b bold, INFO=black,
+ DEBUG=#3fe0a8, TRACE=blue}</pre>
+ #else
+ <pre>%highlight{%d [%t] %-5level: %msg%n%throwable}{FATAL=white, ERROR=red, WARN=bg_#5792e6 fg_#eef26b bold, INFO=black, DEBUG=#3fe0a8, TRACE=blue}</pre>
#end
</p>
Review Comment:
This example should be in the PR #933.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] ppkarwasz merged pull request #935: LOG4J2-3537 Fixes problem with wrong ANSI escape code for bright colors
Posted by GitBox <gi...@apache.org>.
ppkarwasz merged PR #935:
URL: https://github.com/apache/logging-log4j2/pull/935
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org