[GitHub] [incubator-brpc] zyearn commented on a change in pull request #1599: Update http2_rpc_protocol.cpp

[GitBox <gi...@apache.org>]

zyearn commented on a change in pull request #1599:
URL: https://github.com/apache/incubator-brpc/pull/1599#discussion_r745125929



##########
File path: src/brpc/policy/http2_rpc_protocol.cpp
##########
@@ -204,7 +204,7 @@ bool ParseH2Settings(H2Settings* out, butil::IOBufBytesIterator& it, size_t n) {
         default:
             // An endpoint that receives a SETTINGS frame with any unknown or
             // unsupported identifier MUST ignore that setting (section 6.5.2)
-            LOG(WARNING) << "Unknown setting, id=" << id << " value=" << value;
+            // LOG(WARNING) << "Unknown setting, id=" << id << " value=" << value;

Review comment:
       是不是直接删掉就好了




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org