You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2014/04/23 18:32:32 UTC
Review Request 20612: Call for requests with 'page_size' always return 10
most recent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20612/
-----------------------------------------------------------
Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.
Bugs: AMBARI-5546
https://issues.apache.org/jira/browse/AMBARI-5546
Repository: ambari
Description
-------
Problem:
Call: /api/v1/clusters/cl1/requests?to=end&page_size=20
Actually result: return most recent 10 requests
Expected result: return most recent 20 requests.
Call: /api/v1/clusters/cl1/requests?from=start&page_size=3
Actually result: return first 3 requests started from the first in most recent 10
Expected result: return first 3 requests started from the very first('install services')
In this case, we can never get history requests made before most recent 10.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessor.java f83adaf
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java 07e6d5f
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionManager.java 7b9a922
ambari-server/src/main/java/org/apache/ambari/server/api/query/QueryImpl.java 0a0822c
ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseRequest.java 6d9c13b
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java 70f4b75
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/PropertyHelper.java efc7ee4
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java 66c89c0
ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionDBAccessorImpl.java 344891d
ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionManager.java 9cb2199
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java e9bab1a
Diff: https://reviews.apache.org/r/20612/diff/
Testing
-------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [3.276s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.355s]
[INFO] Ambari Web ........................................ SUCCESS [13.844s]
[INFO] Ambari Views ...................................... SUCCESS [1.509s]
[INFO] Ambari Server ..................................... SUCCESS [12:19.800s]
[INFO] Ambari Agent ...................................... SUCCESS [28.429s]
[INFO] Ambari Client ..................................... SUCCESS [0.255s]
Thanks,
Dmytro Sen
Re: Review Request 20612: Call for requests with 'page_size' always return
10 most recent
Posted by Myroslav Papirkovskyy <mp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20612/#review41284
-----------------------------------------------------------
Ship it!
Ship It!
- Myroslav Papirkovskyy
On April 23, 2014, 7:32 p.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20612/
> -----------------------------------------------------------
>
> (Updated April 23, 2014, 7:32 p.m.)
>
>
> Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.
>
>
> Bugs: AMBARI-5546
> https://issues.apache.org/jira/browse/AMBARI-5546
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Problem:
> Call: /api/v1/clusters/cl1/requests?to=end&page_size=20
> Actually result: return most recent 10 requests
> Expected result: return most recent 20 requests.
> Call: /api/v1/clusters/cl1/requests?from=start&page_size=3
> Actually result: return first 3 requests started from the first in most recent 10
> Expected result: return first 3 requests started from the very first('install services')
> In this case, we can never get history requests made before most recent 10.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessor.java f83adaf
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java 07e6d5f
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionManager.java 7b9a922
> ambari-server/src/main/java/org/apache/ambari/server/api/query/QueryImpl.java 0a0822c
> ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseRequest.java 6d9c13b
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java 70f4b75
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/PropertyHelper.java efc7ee4
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java 66c89c0
> ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionDBAccessorImpl.java 344891d
> ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionManager.java 9cb2199
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java e9bab1a
>
> Diff: https://reviews.apache.org/r/20612/diff/
>
>
> Testing
> -------
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [3.276s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.355s]
> [INFO] Ambari Web ........................................ SUCCESS [13.844s]
> [INFO] Ambari Views ...................................... SUCCESS [1.509s]
> [INFO] Ambari Server ..................................... SUCCESS [12:19.800s]
> [INFO] Ambari Agent ...................................... SUCCESS [28.429s]
> [INFO] Ambari Client ..................................... SUCCESS [0.255s]
>
>
> Thanks,
>
> Dmytro Sen
>
>