You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/08/31 08:20:49 UTC
[GitHub] [pulsar] coderzc opened a new pull request, #17369: [fix][flaky-test] Fix RawReaderTest.testFlowControlBatch
coderzc opened a new pull request, #17369:
URL: https://github.com/apache/pulsar/pull/17369
Fixes #17365
### Modifications
The batchingMaxPublishDelay default value is 1ms, it is too less for 5000 messages, so add the batchingMaxPublishDelay value to 1min.
https://github.com/apache/pulsar/blob/c48a3243287c7d775459b6437d9f4b24ed44cf4c/pulsar-broker/src/test/java/org/apache/pulsar/client/impl/RawReaderTest.java#L295-L306
### Documentation
Check the box below or label this PR directly.
Need to update docs?
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [x] `doc-not-needed`
(Please explain why)
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui closed pull request #17369: [fix][flaky-test] Fix RawReaderTest.testFlowControlBatch
Posted by GitBox <gi...@apache.org>.
codelipenghui closed pull request #17369: [fix][flaky-test] Fix RawReaderTest.testFlowControlBatch
URL: https://github.com/apache/pulsar/pull/17369
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #17369: [fix][flaky-test] Fix RawReaderTest.testFlowControlBatch
Posted by GitBox <gi...@apache.org>.
codelipenghui merged PR #17369:
URL: https://github.com/apache/pulsar/pull/17369
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] coderzc commented on a diff in pull request #17369: [fix][flaky-test] Fix RawReaderTest.testFlowControlBatch
Posted by GitBox <gi...@apache.org>.
coderzc commented on code in PR #17369:
URL: https://github.com/apache/pulsar/pull/17369#discussion_r960158252
##########
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/RawReaderTest.java:
##########
@@ -84,6 +83,7 @@ private Set<String> publishMessages(String topic, int count, boolean batching) t
.enableBatching(batching)
// easier to create enough batches with a small batch size
.batchingMaxMessages(10)
+ .batchingMaxPublishDelay(1, TimeUnit.MINUTES)
Review Comment:
It is make sense, we can flush manually after sent the last message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on a diff in pull request #17369: [fix][flaky-test] Fix RawReaderTest.testFlowControlBatch
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on code in PR #17369:
URL: https://github.com/apache/pulsar/pull/17369#discussion_r960128322
##########
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/RawReaderTest.java:
##########
@@ -84,6 +83,7 @@ private Set<String> publishMessages(String topic, int count, boolean batching) t
.enableBatching(batching)
// easier to create enough batches with a small batch size
.batchingMaxMessages(10)
+ .batchingMaxPublishDelay(1, TimeUnit.MINUTES)
Review Comment:
We should flush the batch manually.
This method is used in multiple places.
If the count is not (n * 10), the test will always wait for 1 minute.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] coderzc commented on pull request #17369: [fix][flaky-test] Fix RawReaderTest.testFlowControlBatch
Posted by GitBox <gi...@apache.org>.
coderzc commented on PR #17369:
URL: https://github.com/apache/pulsar/pull/17369#issuecomment-1235435692
@codelipenghui PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org