[GitHub] [orc] pgaref commented on pull request #668: ORC-742: Added Lazy IO for non filter columns

[GitBox <gi...@apache.org>]

pgaref commented on pull request #668:
URL: https://github.com/apache/orc/pull/668#issuecomment-816812024


   > > Left some preliminary comments but my general advice would be to have one final split of this where we just introduce the enums and prepare the Readers for the actual planning/reading changes -- for instance I am sure we can cut down on the places where we pass ReadLevel around, and introduce some overloaded method where necessary.
   > > Then, in the final PR we will then only need to introduce the logic of partialPlan and follow Data Read which will be much cleaner.
   > > Please let me know what you think :)
   > 
   > @pgaref Thanks for your feedback. Instead of separating PRs as the PR with just the level changes does not add any functionality, maybe alternatively shall I break the PR into multiple commits so as to differentiate these changes:
   > 
   > 1. Introduce ReadLevel and add the parameters to the methods
   > 2. Introduce the LazyIO based on the read level
   > 
   > Let me know what you think.
   
   Hey @pavibhai that could also help, see what works better for you :) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org