[GitHub] [felix-dev] cziegeler commented on a diff in pull request #177: FELIX-6570 - Components webconsole-plugin shows password in clear text

[GitBox <gi...@apache.org>]

cziegeler commented on code in PR #177:
URL: https://github.com/apache/felix-dev/pull/177#discussion_r994232080


##########
webconsole-plugins/ds/src/main/java/org/apache/felix/webconsole/plugins/ds/internal/ConfigurationSupport.java:
##########
@@ -73,4 +75,16 @@ public boolean isConfigurable(final Bundle providingBundle, final String pid)
         }
         return false;
     }
+
+    /**
+     * Returns a Collection of IDs of Password Attributes Definitions for given bundle and configuration PIDs
+     * @param bundle The Bundle providing the component
+     * @param configurationPids A non-null configuration pid
+     * @return <code>Collection<String></code>
+     */
+    public Collection<String> getPasswordAttributeDefinitionIds(final Bundle bundle, final String[] configurationPids) {
+        Object metaTypeService = this.metatypeTracker.getService();
+        return new MetatypeSupport().getPasswordAttributeDefinitionIds(metaTypeService, bundle, configurationPids);

Review Comment:
   I think its better to first check metaTypeService for null and only if not null call MetatypeSupport



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@felix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org