You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/02/21 03:35:50 UTC
[GitHub] [incubator-nuttx] yamt opened a new pull request #343: Revert
"README.txt: add MacOS section for flock installation"
yamt opened a new pull request #343: Revert "README.txt: add MacOS section for flock installation"
URL: https://github.com/apache/incubator-nuttx/pull/343
This reverts commit 7a76a97f44138074ebdebd78d997da9381fa3e44.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #343: Revert
"README.txt: add MacOS section for flock installation"
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #343: Revert "README.txt: add MacOS section for flock installation"
URL: https://github.com/apache/incubator-nuttx/pull/343#issuecomment-589518987
> @xiaoxiang781216 it seems using AR via ARNOEMP. but i got your point.
>
> i wrote another alternative. how do you think?
> [apache/incubator-nuttx-apps#83](https://github.com/apache/incubator-nuttx-apps/pull/83)
Has one concern, I reply in that PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #343: Revert
"README.txt: add MacOS section for flock installation"
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #343: Revert "README.txt: add MacOS section for flock installation"
URL: https://github.com/apache/incubator-nuttx/pull/343#issuecomment-589653964
This depend on which approach you want to fix the parellel build issue:
1.Use flock
a.Close this PR directly
b.Merge https://github.com/apache/incubator-nuttx/pull/342 and https://github.com/apache/incubator-nuttx-apps/pull/84
2.Or apply this patch and https://github.com/apache/incubator-nuttx-apps/pull/83
but we may need more test since the change is little big, especially the command line may become very long(basiclly all full path .o archieve into libapps.a in one step).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #343: Revert
"README.txt: add MacOS section for flock installation"
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #343: Revert "README.txt: add MacOS section for flock installation"
URL: https://github.com/apache/incubator-nuttx/pull/343#issuecomment-589649502
@xiaoxiang781216: "we can't assume bash, can we?". Yes, in most cases you can assume bash or similar in all cases except Windows native build. You should try not to break the Windows native build any more that possible. That will be revisited in the near future.
Has this discussion reached a conclusion? Is thie PR ready to be merged?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #343: Revert
"README.txt: add MacOS section for flock installation"
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #343: Revert "README.txt: add MacOS section for flock installation"
URL: https://github.com/apache/incubator-nuttx/pull/343#issuecomment-589486075
> consider this after [apache/incubator-nuttx-apps#81](https://github.com/apache/incubator-nuttx-apps/pull/81)
But that patch will break some arch. If you really want to use shlock on macOS, it is better to add a bash script and call shlock/flock before check the platform, but keep ARCHIEVE call.
BTW, It's better to check the platform in the bash instead Make.defs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on issue #343: Revert "README.txt:
add MacOS section for flock installation"
Posted by GitBox <gi...@apache.org>.
yamt commented on issue #343: Revert "README.txt: add MacOS section for flock installation"
URL: https://github.com/apache/incubator-nuttx/pull/343#issuecomment-589490000
@xiaoxiang781216 which arch does it break?
using shlock on macOS is not the main point of https://github.com/apache/incubator-nuttx-apps/pull/81 .
we can't assume bash, can we? i don't think it's worth to write .bat file for this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #343: Revert
"README.txt: add MacOS section for flock installation"
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #343: Revert "README.txt: add MacOS section for flock installation"
URL: https://github.com/apache/incubator-nuttx/pull/343#issuecomment-589494845
> @xiaoxiang781216 which arch does it break?
> using shlock on macOS is not the main point of [apache/incubator-nuttx-apps#81](https://github.com/apache/incubator-nuttx-apps/pull/81) .
> we can't assume bash, can we? i don't think it's worth to write .bat file for this.
Here:
https://github.com/FishsemiCode/nuttx/blob/song-u1/arch/ceva/src/song/Toolchain.defs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo merged pull request #343: Revert
"README.txt: add MacOS section for flock installation"
Posted by GitBox <gi...@apache.org>.
patacongo merged pull request #343: Revert "README.txt: add MacOS section for flock installation"
URL: https://github.com/apache/incubator-nuttx/pull/343
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on issue #343: Revert "README.txt:
add MacOS section for flock installation"
Posted by GitBox <gi...@apache.org>.
yamt commented on issue #343: Revert "README.txt: add MacOS section for flock installation"
URL: https://github.com/apache/incubator-nuttx/pull/343#issuecomment-589502915
@xiaoxiang781216 it seems using AR via ARNOEMP. but i got your point.
i wrote another alternative. how do you think?
https://github.com/apache/incubator-nuttx-apps/pull/83
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on issue #343: Revert "README.txt:
add MacOS section for flock installation"
Posted by GitBox <gi...@apache.org>.
yamt commented on issue #343: Revert "README.txt: add MacOS section for flock installation"
URL: https://github.com/apache/incubator-nuttx/pull/343#issuecomment-589482714
consider this after https://github.com/apache/incubator-nuttx-apps/pull/81
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on issue #343:
Revert "README.txt: add MacOS section for flock installation"
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on issue #343: Revert "README.txt: add MacOS section for flock installation"
URL: https://github.com/apache/incubator-nuttx/pull/343#issuecomment-589494845
> @xiaoxiang781216 which arch does it break?
> using shlock on macOS is not the main point of [apache/incubator-nuttx-apps#81](https://github.com/apache/incubator-nuttx-apps/pull/81) .
> we can't assume bash, can we? i don't think it's worth to write .bat file for this.
Here:
https://github.com/FishsemiCode/nuttx/blob/song-u1/arch/ceva/src/song/Toolchain.defs
And you can see we don't define AR at all.
By desgin, the interface between the common Makefile and toolchain is ARCHIVE/COMIPLE... and the comment said that the user can overwrite these macros as need. AR/CC isn't public interface.
If we take your approach: we should use AR/CC.. directly and then ARCHIVE/COMPILE should be removed to avoid the confusion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #343: Revert
"README.txt: add MacOS section for flock installation"
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #343: Revert "README.txt: add MacOS section for flock installation"
URL: https://github.com/apache/incubator-nuttx/pull/343#issuecomment-589635673
The z80 and z16 families are different becuse the ZDS II archiver will only archive one file at a time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services