You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Yonik Seeley (Commented) (JIRA)" <ji...@apache.org> on 2012/02/03 16:25:53 UTC
[jira] [Commented] (SOLR-3093) Remove unused features
and
[ https://issues.apache.org/jira/browse/SOLR-3093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13199768#comment-13199768 ]
Yonik Seeley commented on SOLR-3093:
------------------------------------
bq. and we fail hard if we find this config option in solrconfig.xml
It's just an optimization, so no need to fail. Just remove all traces completely IMO.
> Remove unused features <boolTofilterOptimizer> and <HashDocSet>
> ---------------------------------------------------------------
>
> Key: SOLR-3093
> URL: https://issues.apache.org/jira/browse/SOLR-3093
> Project: Solr
> Issue Type: Improvement
> Reporter: Jan Høydahl
> Fix For: 3.6, 4.0
>
>
> SolrConfig.java still tries to parse <boolTofilterOptimizer>
> But the only user of this param was SolrIndexSearcher.java line 366-381 which is commented out.
> Probably the whole logic should be ripped out, and we fail hard if we find this config option in solrconfig.xml
> Also, the <HashDocSet> config option is old and no longer used or needed? There is some code which tries to use it but I believe that since 1.4 there are more efficient ways to do the same. Should we also fail-fast if found in config or only print a warning?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org