You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Nocera60 (via GitHub)" <gi...@apache.org> on 2025/12/10 01:35:53 UTC
[PR] [EMAIL-208] Updated the default value [commons-email]
Nocera60 opened a new pull request, #393:
URL: https://github.com/apache/commons-email/pull/393
The default `checkserveridentity` value changed in Jakarta EE to `true` which broke support for disabling server identy checking via `setSSLCheckServerIdentity(final boolean sslCheckServerIdentity)`.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
https://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for your contribution to [Apache Commons](https://commons.apache.org/)! Your help is appreciated!
Before you push a pull request, review this list:
- [ ] Read the [contribution guidelines](CONTRIBUTING.md) for this project.
- [ ] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI).
- [ ] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute?
- [ ] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself.
- [ ] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [EMAIL-208] Updated the default sslCheckServerIdentity value [commons-email]
Posted by "Trustinbtc999-hue (via GitHub)" <gi...@apache.org>.
Trustinbtc999-hue commented on PR #393:
URL: https://github.com/apache/commons-email/pull/393#issuecomment-4595354846
What do I do
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [EMAIL-208] Updated the default sslCheckServerIdentity value [commons-email]
Posted by "Trustinbtc999-hue (via GitHub)" <gi...@apache.org>.
Trustinbtc999-hue commented on code in PR #393:
URL: https://github.com/apache/commons-email/pull/393#discussion_r3360183578
##########
commons-email2-jakarta/src/main/java/org/apache/commons/mail2/jakarta/Email.java:
##########
@@ -830,8 +830,8 @@ public Session getMailSession() throws EmailException {
properties.setProperty(EmailConstants.MAIL_SMTP_SOCKET_FACTORY_FALLBACK, "false");
}
- if ((isSSLOnConnect() || isStartTLSEnabled()) && isSSLCheckServerIdentity()) {
Review Comment:
What's going on with this?
##########
commons-email2-jakarta/src/main/java/org/apache/commons/mail2/jakarta/Email.java:
##########
@@ -221,9 +221,9 @@ public abstract class Email {
/**
* If set to true, check the server identity as specified by RFC 2595. These additional checks based on the content of the server's certificate are intended
- * to prevent man-in-the-middle attacks. Defaults to false.
Review Comment:
How do I fix this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [EMAIL-208] Updated the default sslCheckServerIdentity value [commons-email]
Posted by "Trustinbtc999-hue (via GitHub)" <gi...@apache.org>.
Trustinbtc999-hue commented on code in PR #393:
URL: https://github.com/apache/commons-email/pull/393#discussion_r3360181994
##########
commons-email2-jakarta/src/main/java/org/apache/commons/mail2/jakarta/Email.java:
##########
@@ -221,9 +221,9 @@ public abstract class Email {
/**
* If set to true, check the server identity as specified by RFC 2595. These additional checks based on the content of the server's certificate are intended
- * to prevent man-in-the-middle attacks. Defaults to false.
Review Comment:
How do I fix this?
##########
commons-email2-jakarta/src/main/java/org/apache/commons/mail2/jakarta/Email.java:
##########
@@ -830,8 +830,8 @@ public Session getMailSession() throws EmailException {
properties.setProperty(EmailConstants.MAIL_SMTP_SOCKET_FACTORY_FALLBACK, "false");
}
- if ((isSSLOnConnect() || isStartTLSEnabled()) && isSSLCheckServerIdentity()) {
Review Comment:
What's going on with this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [EMAIL-208] Updated the default sslCheckServerIdentity value [commons-email]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #393:
URL: https://github.com/apache/commons-email/pull/393#issuecomment-4586475732
-1: This PR contains no unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [EMAIL-208] Updated the default sslCheckServerIdentity value [commons-email]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #393:
URL: https://github.com/apache/commons-email/pull/393#issuecomment-5122736239
Converted to draft until tests come in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [EMAIL-208] Updated the default sslCheckServerIdentity value [commons-email]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #393:
URL: https://github.com/apache/commons-email/pull/393#issuecomment-4703340933
Hello @Trustinbtc999-hue Your approval is meaningless without unit tests 😞
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org