You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/07 00:50:13 UTC

[GitHub] [arrow-rs] HaoYang670 commented on a diff in pull request #1664: Replace `fn is_large` with `const IS_LARGE`

HaoYang670 commented on code in PR #1664:
URL: https://github.com/apache/arrow-rs/pull/1664#discussion_r867279175


##########
arrow/src/array/array_binary.rs:
##########
@@ -44,8 +44,11 @@ pub struct GenericBinaryArray<OffsetSize: OffsetSizeTrait> {
 }
 
 impl<OffsetSize: OffsetSizeTrait> GenericBinaryArray<OffsetSize> {
+    /// Get the data type of the array.
+    // Declare this function as `pub const fn` after
+    // https://github.com/rust-lang/rust/issues/93706 is merged.

Review Comment:
   I just want to make the first line (`Get the data type of the array.`) be the doc of this function. And it is not necessary to expose the 2nd and 3rd line to users, so I use `//`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org