[GitHub] [fineract] galovics commented on a diff in pull request #2889: FINERACT-1806: Trigger event when charge-off happens

[GitBox <gi...@apache.org>]

galovics commented on code in PR #2889:
URL: https://github.com/apache/fineract/pull/2889#discussion_r1072063934


##########
fineract-avro-schemas/src/main/avro/loan/v1/UnpaidChargeDataV1.avsc:
##########
@@ -0,0 +1,31 @@
+{
+    "name": "UnpaidChargeDataV1",
+    "namespace": "org.apache.fineract.avro.loan.v1",
+    "type": "record",
+    "fields": [
+        {
+            "default": null,
+            "name": "chargeId",
+            "type": [
+                "null",

Review Comment:
   This cannot be null, can it?



##########
fineract-avro-schemas/src/main/avro/loan/v1/UnpaidChargeDataV1.avsc:
##########
@@ -0,0 +1,31 @@
+{
+    "name": "UnpaidChargeDataV1",
+    "namespace": "org.apache.fineract.avro.loan.v1",
+    "type": "record",
+    "fields": [
+        {
+            "default": null,
+            "name": "chargeId",
+            "type": [
+                "null",
+                "long"
+            ]
+        },
+        {
+            "default": null,
+            "name": "chargeName",

Review Comment:
   Same here, name is mandatory for charges, isn't it?



##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/data/UnpaidChargeData.java:
##########
@@ -0,0 +1,39 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.fineract.portfolio.loanaccount.data;
+
+import java.math.BigDecimal;
+import lombok.Getter;
+
+/**
+ * Immutable data object representing the total unpaid charge details
+ */
+@Getter
+public class UnpaidChargeData {
+
+    private final Long chargeId;
+    private final String chargeName;
+    private final BigDecimal outstandingAmount;
+
+    public UnpaidChargeData(Long chargeId, String chargeName, BigDecimal outstandingAmount) {

Review Comment:
   Note if what I wrote in the Avro schema is true (i.e. not null values) then let's add null checks here to ensure we cannot create this object without having proper data in it.



##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/event/external/service/serialization/mapper/loan/LoanAccountDataMapper.java:
##########
@@ -36,5 +36,6 @@ public interface LoanAccountDataMapper {
     @Mapping(source = "interestRecalculationEnabled", target = "isInterestRecalculationEnabled")
     LoanAccountDataV1 map(LoanAccountData source);
 
+    @Mapping(target = "unpaidCharges", ignore = true)

Review Comment:
   I don't think we even need this method here.
   We could just modify the annotation on the class to this:
   ```
   @Mapper(config = AvroMapperConfig.class, uses = { LoanTransactionDataMapper.class })
   ```



##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/event/external/service/serialization/mapper/loan/LoanTransactionDataMapper.java:
##########
@@ -22,9 +22,11 @@
 import org.apache.fineract.infrastructure.event.external.service.serialization.mapper.support.AvroMapperConfig;
 import org.apache.fineract.portfolio.loanaccount.data.LoanTransactionData;
 import org.mapstruct.Mapper;
+import org.mapstruct.Mapping;
 
 @Mapper(config = AvroMapperConfig.class)
 public interface LoanTransactionDataMapper {
 
+    @Mapping(target = "unpaidCharges", ignore = true)

Review Comment:
   Can we put a comment here why this is ignored? Just for future reference.



##########
fineract-avro-schemas/src/main/avro/loan/v1/UnpaidChargeDataV1.avsc:
##########
@@ -0,0 +1,31 @@
+{
+    "name": "UnpaidChargeDataV1",
+    "namespace": "org.apache.fineract.avro.loan.v1",
+    "type": "record",
+    "fields": [
+        {
+            "default": null,
+            "name": "chargeId",
+            "type": [
+                "null",
+                "long"
+            ]
+        },
+        {
+            "default": null,
+            "name": "chargeName",
+            "type": [
+                "null",
+                "string"
+            ]
+        },
+        {
+            "default": null,
+            "name": "outstandingAmount",

Review Comment:
   Can this be null or only zero?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org