You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/09/12 15:02:06 UTC
[GitHub] [pulsar] xuesongxs opened a new pull request #8044: add Pulsar IO :: RocketMQ
xuesongxs opened a new pull request #8044:
URL: https://github.com/apache/pulsar/pull/8044
<!--
### Contribution Checklist
- Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where *XYZ* should be replaced by the actual issue number.
Skip *Issue XYZ* if there is no associated github issue for this pull request.
Skip *component* if you are unsure about which is the best component. E.g. `[docs] Fix typo in produce method`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
*(If this PR fixes a github issue, please add `Fixes #<xyz>`.)*
Fixes #8043
*(or if this PR is one task of a github issue, please add `Master Issue: #<xyz>` to link to the master issue.)*
Master Issue: #8043
### Motivation
add Pulsar IO :: RocketMQ, RocketMQSource and RocketMQSink
### Modifications
add Pulsar IO :: RocketMQ, RocketMQSource and RocketMQSink
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API: (yes / no)
- The schema: (yes / no / don't know)
- The default values of configurations: (yes / no)
- The wire protocol: (yes / no)
- The rest endpoints: (yes / no)
- The admin cli options: (yes / no)
- Anything that affects deployment: (yes / no / don't know)
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aahmed-se commented on pull request #8044: Add Pulsar IO :: RocketMQ
Posted by GitBox <gi...@apache.org>.
aahmed-se commented on pull request #8044:
URL: https://github.com/apache/pulsar/pull/8044#issuecomment-691776265
@jiazhai @xuesongxs I recommend we add new connectors here.
https://github.com/apache/pulsar-connectors
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8044: Add Pulsar IO :: RocketMQ
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8044:
URL: https://github.com/apache/pulsar/pull/8044#issuecomment-843814570
Close this PR first, I have a discussion with @xuesongxs and he is not able to get a chance to complete the PR. And as @aahmed-se mentioned it able to maintain the connectors in https://github.com/apache/pulsar-connectors
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui closed pull request #8044: Add Pulsar IO :: RocketMQ
Posted by GitBox <gi...@apache.org>.
codelipenghui closed pull request #8044:
URL: https://github.com/apache/pulsar/pull/8044
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] xuesongxs commented on pull request #8044: Add Pulsar IO :: RocketMQ
Posted by GitBox <gi...@apache.org>.
xuesongxs commented on pull request #8044:
URL: https://github.com/apache/pulsar/pull/8044#issuecomment-691754982
> Thanks for the help @xuesongxs , seems the connector functionality not tested, Would you please help add some read/write tests in the integration tests? It would help a lot to protect this part of code.
OK, I'll do it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jiazhai commented on pull request #8044: Add Pulsar IO :: RocketMQ
Posted by GitBox <gi...@apache.org>.
jiazhai commented on pull request #8044:
URL: https://github.com/apache/pulsar/pull/8044#issuecomment-691751638
Thanks for the help @xuesongxs , seems the connector functionality not tested, Would you please help add some read/write tests in the integration tests? It would help a lot to protect this part of code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org