You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/03/07 09:13:56 UTC
[GitHub] [airflow] Wilderone opened a new pull request #22041: Fix/21994 liveness probe
Wilderone opened a new pull request #22041:
URL: https://github.com/apache/airflow/pull/22041
This MR resolve two problems:
1. Remove "exec" argument for sh in livenessProbe, because of this leads to false-success of probe check
2. Move livenessProbe's code to values, so client can redefine it.
Related issue https://github.com/apache/airflow/issues/21994
I am not sure about version of this change, so just upgrade patch version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #22041: Fix/21994 liveness probe
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #22041:
URL: https://github.com/apache/airflow/pull/22041#discussion_r820592554
##########
File path: chart/Chart.yaml
##########
@@ -19,7 +19,7 @@
---
apiVersion: v2
name: airflow
-version: 1.5.0-dev
+version: 1.5.1-dev
Review comment:
I tihnk this should not be changed. We are voting on 1.5.0 and my bet is that we will issue and rc2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22041: Fix/21994 liveness probe
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #22041:
URL: https://github.com/apache/airflow/pull/22041#issuecomment-1060660522
(and removal of the version change too :))
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a change in pull request #22041: Fix/21994 liveness probe
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on a change in pull request #22041:
URL: https://github.com/apache/airflow/pull/22041#discussion_r820907985
##########
File path: chart/Chart.yaml
##########
@@ -19,7 +19,7 @@
---
apiVersion: v2
name: airflow
-version: 1.5.0-dev
+version: 1.5.1-dev
Review comment:
Yeah, we don't need to touch this here.
##########
File path: chart/values.schema.json
##########
@@ -1504,6 +1504,20 @@
"description": "How often (in seconds) to perform the probe. Minimum value is 1.",
"type": "integer",
"default": 60
+ },
+ "exec": {
+ "description": "Custom exec command for livenessProbe",
Review comment:
```suggestion
"description": "Command for livenessProbe",
```
I'm also not sure we need to maintain the nesting of `exec.command`. I'd rather we flatten it and just have `livenessProbe.command`. My 2c, thoughts?
##########
File path: chart/values.yaml
##########
@@ -563,6 +563,24 @@ scheduler:
timeoutSeconds: 20
failureThreshold: 5
periodSeconds: 60
+ exec:
+ command:
+ - sh
+ - -c
+ - |
+ CONNECTION_CHECK_MAX_COUNT=0 /entrypoint python -Wignore -c "
Review comment:
```suggestion
CONNECTION_CHECK_MAX_COUNT=0 exec /entrypoint python -Wignore -c "
```
This is where the exec should be, and I think we want to keep it so `timeoutSeconds` can actually function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on pull request #22041: Fix/21994 liveness probe
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on pull request #22041:
URL: https://github.com/apache/airflow/pull/22041#issuecomment-1061946359
Thanks @Wilderone! Congrats on your first commit π
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #22041: Fix/21994 liveness probe
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #22041:
URL: https://github.com/apache/airflow/pull/22041#issuecomment-1061942148
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #22041: Fix/21994 liveness probe
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #22041:
URL: https://github.com/apache/airflow/pull/22041
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #22041: Fix/21994 liveness probe
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #22041:
URL: https://github.com/apache/airflow/pull/22041#issuecomment-1060513098
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #22041: Fix/21994 liveness probe
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #22041:
URL: https://github.com/apache/airflow/pull/22041#issuecomment-1060370658
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, itβs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better π.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22041: Fix/21994 liveness probe
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #22041:
URL: https://github.com/apache/airflow/pull/22041#issuecomment-1060660227
The mypy static checks are unrelated (and already fixed in `main` - can you please rebase and fix the other static check (which is related :)). Pre-commit might help you with automatically fixing it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #22041: Fix/21994 liveness probe
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #22041:
URL: https://github.com/apache/airflow/pull/22041#discussion_r821183163
##########
File path: chart/values.yaml
##########
@@ -563,6 +563,24 @@ scheduler:
timeoutSeconds: 20
failureThreshold: 5
periodSeconds: 60
+ exec:
+ command:
+ - sh
+ - -c
+ - |
+ CONNECTION_CHECK_MAX_COUNT=0 /entrypoint python -Wignore -c "
Review comment:
Yep.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #22041: Fix/21994 liveness probe
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #22041:
URL: https://github.com/apache/airflow/pull/22041#discussion_r821564793
##########
File path: chart/tests/test_scheduler.py
##########
@@ -235,6 +236,9 @@ def test_livenessprobe_values_are_configurable(self):
"spec.template.spec.containers[0].livenessProbe.failureThreshold", docs[0]
)
assert 444 == jmespath.search("spec.template.spec.containers[0].livenessProbe.periodSeconds", docs[0])
+ assert ["sh", "-c", "echo", "wow such test"] == jmespath.search(
Review comment:
:smile:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org