[jira] [Resolved] (FELIX-5432) Message when dependency is already added to a component is incomplete

["Pierre De Rop (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/FELIX-5432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pierre De Rop resolved FELIX-5432.
----------------------------------
    Resolution: Fixed

I applied your fix in revision 1772583 (thank you).

> Message when dependency is already added to a component is incomplete
> ---------------------------------------------------------------------
>
>                 Key: FELIX-5432
>                 URL: https://issues.apache.org/jira/browse/FELIX-5432
>             Project: Felix
>          Issue Type: Improvement
>          Components: Dependency Manager
>    Affects Versions: org.apache.felix.dependencymanager-r8
>            Reporter: Jeroen Daanen
>            Assignee: Pierre De Rop
>            Priority: Minor
>
> If a dependency is added to a component, while the dependency has already been added to another component, the error message does not contain information to which component it was added already (while that information is available).
> Probably it would be better to change the code in ComponentImpl.add(Dependency...)
> {code}
> if (dc.getComponentContext() != null) {
> m_logger.err("%s can't be added to %s (dependency already added to component %s).", dc, ComponentImpl.this, dc.getComponentContext());
> continue;
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)