You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@twill.apache.org by fonelor <gi...@git.apache.org> on 2017/07/08 11:27:09 UTC
[GitHub] twill pull request #56: implemented issue TWILL-238: restart instances with ...
GitHub user fonelor opened a pull request:
https://github.com/apache/twill/pull/56
implemented issue TWILL-238: restart instances with Set of Integers
Implemented https://issues.apache.org/jira/browse/TWILL-238
New method in TwillController to restart instances of runnable
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fonelor/twill feature/238_restartinstances_api
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/twill/pull/56.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #56
----
commit eb184e6aa727d93fce4e6e4e33c729eb09017750
Author: Sergey Filippov <fi...@yandex.ru>
Date: 2017-07-08T11:24:22Z
implemented issue TWILL-238: restart instances with Set of Integers
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] twill issue #56: (TWILL-238) Change TwillController restartInstances API
Posted by chtyim <gi...@git.apache.org>.
Github user chtyim commented on the issue:
https://github.com/apache/twill/pull/56
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] twill pull request #56: (TWILL-238) Change TwillController restartInstances ...
Posted by chtyim <gi...@git.apache.org>.
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/56#discussion_r126296669
--- Diff: twill-api/src/main/java/org/apache/twill/api/TwillController.java ---
@@ -17,15 +17,14 @@
*/
package org.apache.twill.api;
-import org.apache.twill.api.logging.LogEntry;
-import org.apache.twill.api.logging.LogHandler;
-import org.apache.twill.discovery.Discoverable;
-import org.apache.twill.discovery.ServiceDiscovered;
-
import java.util.Map;
import java.util.Set;
import java.util.concurrent.Future;
import javax.annotation.Nullable;
+import org.apache.twill.api.logging.LogEntry;
--- End diff --
Please don't rearrange the imports. You can use the ide profiles available in http://twill.apache.org/HowToContribute.html
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] twill issue #56: (TWILL-238) Change TwillController restartInstances API
Posted by fonelor <gi...@git.apache.org>.
Github user fonelor commented on the issue:
https://github.com/apache/twill/pull/56
Thank you, serranom, for your comment. Is there any way to set "right" order of imports in IDEA? I've imported settings from HowToContribute page, but it seems, that it still wants to move imports.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] twill pull request #56: (TWILL-238) Change TwillController restartInstances ...
Posted by fonelor <gi...@git.apache.org>.
Github user fonelor commented on a diff in the pull request:
https://github.com/apache/twill/pull/56#discussion_r127425262
--- Diff: twill-api/src/main/java/org/apache/twill/api/TwillController.java ---
@@ -17,15 +17,14 @@
*/
package org.apache.twill.api;
-import org.apache.twill.api.logging.LogEntry;
-import org.apache.twill.api.logging.LogHandler;
-import org.apache.twill.discovery.Discoverable;
-import org.apache.twill.discovery.ServiceDiscovered;
-
import java.util.Map;
import java.util.Set;
import java.util.concurrent.Future;
import javax.annotation.Nullable;
+import org.apache.twill.api.logging.LogEntry;
--- End diff --
i've reverted reformatting changes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] twill pull request #56: (TWILL-238) Change TwillController restartInstances ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/twill/pull/56
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] twill issue #56: (TWILL-238) Change TwillController restartInstances API
Posted by fonelor <gi...@git.apache.org>.
Github user fonelor commented on the issue:
https://github.com/apache/twill/pull/56
Reverted reformatting
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---