You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@stratos.apache.org by Vishanth Balasubramaniam <vi...@wso2.com> on 2015/03/24 11:48:12 UTC

[Code Review] Refining cartridge classes in cloud controller

Hi Devs,

Let's have a code review on the $subject at 4.30pm on 24th March, 2015.
Will be reviewing the pull request [1]. Please find the hangout event
happening at [2].

[1] - https://github.com/apache/stratos/pull/277
[2] -
https://plus.google.com/hangouts/_/event/cmeqje6bnd2mdggq00ltrcp8hkc?authuser=1&hl=en

Thank you,
Vishanth

-- 
*Vishanth Balasubramaniam*
Software Engineer
WSO2 Inc.; http://wso2.com
lean.enterprise.middleware

mobile: *+94771737718*
about me: *http://about.me/vishanth <http://about.me/vishanth>*

Re: [Code Review] Refining cartridge classes in cloud controller

Posted by Chamila De Alwis <ch...@wso2.com>.

Hi,

Please find the review notes as follows.


   1.

   Improvements
   1.

      Variable names - cartridgeInfo to cartridge
      2.

      cartridgeId can be named to cartridgeType
      3.

      Iterator.remove() in CloudControllerContext
      4.

      keySet() replaced by entrySet() and while(iterator.hasNext())
      CloudControllerContext



   1.

   Main changes done
   1.

      Refactored to avoid exposing Jclouds from WSDL file
      2. Lists, enums changed to be compatible with Axis2



Regards,
Chamila de Alwis
Software Engineer | WSO2 | +94772207163
Blog: code.chamiladealwis.com



On Tue, Mar 24, 2015 at 4:45 PM, Vishanth Balasubramaniam <
vishanthb@wso2.com> wrote:

> Please find the hangout on air link [1]
>
> [1] -
> https://plus.google.com/hangouts/_/hoaevent/AP36tYemGLJX0r3zyGR3yq4HVa6bAwZQtuF1PhxqQqtz7_x2MEieLg?authuser=0&hl=en
>
> On Tue, Mar 24, 2015 at 4:18 PM, Vishanth Balasubramaniam <
> vishanthb@wso2.com> wrote:
>
>> Hi Devs,
>>
>> Let's have a code review on the $subject at 4.30pm on 24th March, 2015.
>> Will be reviewing the pull request [1]. Please find the hangout event
>> happening at [2].
>>
>> [1] - https://github.com/apache/stratos/pull/277
>> [2] -
>> https://plus.google.com/hangouts/_/event/cmeqje6bnd2mdggq00ltrcp8hkc?authuser=1&hl=en
>>
>> Thank you,
>> Vishanth
>>
>> --
>> *Vishanth Balasubramaniam*
>> Software Engineer
>> WSO2 Inc.; http://wso2.com
>> lean.enterprise.middleware
>>
>> mobile: *+94771737718*
>> about me: *http://about.me/vishanth <http://about.me/vishanth>*
>>
>>
>
>
> --
> *Vishanth Balasubramaniam*
> Software Engineer
> WSO2 Inc.; http://wso2.com
> lean.enterprise.middleware
>
> mobile: *+94771737718*
> about me: *http://about.me/vishanth <http://about.me/vishanth>*
>
>

Re: [Code Review] Refining cartridge classes in cloud controller

Posted by Vishanth Balasubramaniam <vi...@wso2.com>.

Please find the hangout on air link [1]

[1] -
https://plus.google.com/hangouts/_/hoaevent/AP36tYemGLJX0r3zyGR3yq4HVa6bAwZQtuF1PhxqQqtz7_x2MEieLg?authuser=0&hl=en

On Tue, Mar 24, 2015 at 4:18 PM, Vishanth Balasubramaniam <
vishanthb@wso2.com> wrote:

> Hi Devs,
>
> Let's have a code review on the $subject at 4.30pm on 24th March, 2015.
> Will be reviewing the pull request [1]. Please find the hangout event
> happening at [2].
>
> [1] - https://github.com/apache/stratos/pull/277
> [2] -
> https://plus.google.com/hangouts/_/event/cmeqje6bnd2mdggq00ltrcp8hkc?authuser=1&hl=en
>
> Thank you,
> Vishanth
>
> --
> *Vishanth Balasubramaniam*
> Software Engineer
> WSO2 Inc.; http://wso2.com
> lean.enterprise.middleware
>
> mobile: *+94771737718*
> about me: *http://about.me/vishanth <http://about.me/vishanth>*
>
>


-- 
*Vishanth Balasubramaniam*
Software Engineer
WSO2 Inc.; http://wso2.com
lean.enterprise.middleware

mobile: *+94771737718*
about me: *http://about.me/vishanth <http://about.me/vishanth>*