[GitHub] [arrow-datafusion] AssHero commented on a diff in pull request #4394: improve hashjoin execution metrics

[GitBox <gi...@apache.org>]

AssHero commented on code in PR #4394:
URL: https://github.com/apache/arrow-datafusion/pull/4394#discussion_r1033497522


##########
datafusion/core/src/physical_plan/joins/hash_join.rs:
##########
@@ -376,7 +381,8 @@ impl ExecutionPlan for HashJoinExec {
     ) -> Result<SendableRecordBatchStream> {
         let on_left = self.on.iter().map(|on| on.0.clone()).collect::<Vec<_>>();
         let on_right = self.on.iter().map(|on| on.1.clone()).collect::<Vec<_>>();
-
+        let hashjoin_metrics = HashJoinMetrics::new(partition, &self.metrics);
+        let timer = hashjoin_metrics.build_time.timer();
         let left_fut = match self.mode {

Review Comment:
   > Is it correct to calculate the build time here? The `left_fut` returned here is a `Future`.
   
   Thanks！I'll check this code later.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org