You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/03/20 20:43:40 UTC

Re: Review Request 66096: Adapted the new `grpcpp` C++ header for gRPC v1.10 in libprocess.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66096/
-----------------------------------------------------------

(Updated March 20, 2018, 8:43 p.m.)


Review request for mesos, Benjamin Bannier and Jie Yu.


Changes
-------

Addressed Benjamin's comment.


Summary (updated)
-----------------

Adapted the new `grpcpp` C++ header for gRPC v1.10 in libprocess.


Bugs: MESOS-8678
    https://issues.apache.org/jira/browse/MESOS-8678


Repository: mesos


Description (updated)
-------

This patch replaces the use of `grpc++/grpc++.h`, which is deprecated in
upstream gRPC releases, with the new `grpcpp/grpcpp.h` header. There is
no functional change between these two headers.


Diffs
-----

  3rdparty/libprocess/configure.ac 69ec9b9683199f580405e38ec16a581a01f919c4 
  3rdparty/libprocess/include/process/grpc.hpp edaf0410c62454df53d06957a4a8f1f6027b00bb 


Diff: https://reviews.apache.org/r/66096/diff/1/


Testing
-------

`sudo make check` for Mesos and libprocess.


Thanks,

Chun-Hung Hsiao