You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openjpa.apache.org by "Kevin Sutter (Commented) (JIRA)" <ji...@apache.org> on 2012/04/13 16:16:20 UTC
[jira] [Commented] (OPENJPA-2171) asm should be optional
[ https://issues.apache.org/jira/browse/OPENJPA-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13253400#comment-13253400 ]
Kevin Sutter commented on OPENJPA-2171:
---------------------------------------
Can you help us understand the basic issue so that we can resolve this appropriately? Is the basic issue because OpenJPA has introduced a maven dependency on ASM 3.2? Or, is it due to the fact that we have now included the asm binaries in our openjpa-all jar file? And, are those asm binaries causing conflicts with asm usage by TomEE? I looked at the maven shade plugin (http://maven.apache.org/plugins/maven-shade-plugin/), but I'm wondering how that would affect those OpenJPA users that are okay with our current setup. For example, other OpenJPA users could be using our jar file that does not contain all of the dependencies and just substitute their own copies (for example, the consumer is already using asm 3.2, so we're good to go). Do users of the shade plugin end up providing both shaded and non-shaded versions of the jar files? And, why is ASM the concern? Wouldn't this same concern apply to other open-source dependencies that are specified (apache commons, derby, etc)?
Just looking for some more background and justification for this type of change. Thanks.
> asm should be optional
> ----------------------
>
> Key: OPENJPA-2171
> URL: https://issues.apache.org/jira/browse/OPENJPA-2171
> Project: OpenJPA
> Issue Type: Improvement
> Reporter: Romain Manni-Bucau
>
> openjpa uses since some versions asm but in tomee for instance we use a shade (through the xbean one org.apache.xbean:xbean-asm-shaded to avoid classloading/version issues with webapps/applications.
> it can be nice if openjpa can provide us an issue to this because we really don't want to provide asm in our binaries.
> solutions can be to use the xbean shade, give us an interface to implement or to try several implementation (xbean shade, asm,...) by reflection
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira