svn commit: r1888027 - /pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSStream.java

[ti...@apache.org]

Author: tilman
Date: Wed Mar 24 18:45:56 2021
New Revision: 1888027

URL: http://svn.apache.org/viewvc?rev=1888027&view=rev
Log:
PDFBOX-4892: improve speed, as suggested by valerybokov; use try-with-resources

Modified:
    pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSStream.java

Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSStream.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSStream.java?rev=1888027&r1=1888026&r2=1888027&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSStream.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSStream.java Wed Mar 24 18:45:56 2021
@@ -383,24 +383,17 @@ public class COSStream extends COSDictio
      */
     public String toTextString()
     {
-        ByteArrayOutputStream out = new ByteArrayOutputStream();
-        InputStream input = null;
-        try
+        try (InputStream input = createInputStream())
         {
-            input = createInputStream();
-            IOUtils.copy(input, out);
+            byte[] array = IOUtils.toByteArray(input);
+            COSString string = new COSString(array);
+            return string.getString();
         }
         catch (IOException e)
         {
             LOG.debug("An exception occurred trying to get the content - returning empty string instead", e);
             return "";
         }
-        finally
-        {
-            IOUtils.closeQuietly(input);
-        }
-        COSString string = new COSString(out.toByteArray());
-        return string.getString();
     }
     
     @Override