You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2019/03/04 14:31:00 UTC
[jira] [Commented] (OOZIE-3335) Cleanup parseFilter methods
[ https://issues.apache.org/jira/browse/OOZIE-3335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16783421#comment-16783421 ]
Hadoop QA commented on OOZIE-3335:
----------------------------------
PreCommit-OOZIE-Build started
> Cleanup parseFilter methods
> ---------------------------
>
> Key: OOZIE-3335
> URL: https://issues.apache.org/jira/browse/OOZIE-3335
> Project: Oozie
> Issue Type: Improvement
> Components: core
> Affects Versions: trunk
> Reporter: Andras Salamon
> Assignee: Andras Salamon
> Priority: Minor
> Attachments: OOZIE-3335-01-wip.patch
>
>
> TheĀ {{parseFilter}} method is implemented several times in oozie:
> {noformat}
> servlet/SLAServlet.java
> util/JobsFilterUtils.java
> DagEngine.java
> CoordinatorEngine.java (parseJobFilter and parseJobsFilter methods)
> BundleEngine.java (parseBulkFilter method){noformat}
> The implementations are quite similar. Code duplication should be eliminated.
> OOZIE-3229 will introduce a new utility class for filter parsing, all the other classes should use it as well.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)