You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by ch...@apache.org on 2018/01/08 19:22:11 UTC
[5/9] flink git commit: [FLINK-8250][runtime] Remove unused
RecordSerializer#instantiateMetrics
[FLINK-8250][runtime] Remove unused RecordSerializer#instantiateMetrics
This closes #5162.
Project: http://git-wip-us.apache.org/repos/asf/flink/repo
Commit: http://git-wip-us.apache.org/repos/asf/flink/commit/10aae991
Tree: http://git-wip-us.apache.org/repos/asf/flink/tree/10aae991
Diff: http://git-wip-us.apache.org/repos/asf/flink/diff/10aae991
Branch: refs/heads/master
Commit: 10aae991833447506e8e8231c32fb9f816920597
Parents: 5030125
Author: zentol <ch...@apache.org>
Authored: Wed Dec 13 13:23:15 2017 +0100
Committer: zentol <ch...@apache.org>
Committed: Mon Jan 8 18:47:07 2018 +0100
----------------------------------------------------------------------
.../io/network/api/serialization/RecordSerializer.java | 8 --------
.../network/api/serialization/SpanningRecordSerializer.java | 5 -----
2 files changed, 13 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flink/blob/10aae991/flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/serialization/RecordSerializer.java
----------------------------------------------------------------------
diff --git a/flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/serialization/RecordSerializer.java b/flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/serialization/RecordSerializer.java
index 6a07f31..f09bd4a 100644
--- a/flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/serialization/RecordSerializer.java
+++ b/flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/serialization/RecordSerializer.java
@@ -22,7 +22,6 @@ package org.apache.flink.runtime.io.network.api.serialization;
import org.apache.flink.core.io.IOReadableWritable;
import org.apache.flink.runtime.io.network.buffer.Buffer;
import org.apache.flink.runtime.io.network.buffer.BufferBuilder;
-import org.apache.flink.runtime.metrics.groups.TaskIOMetricGroup;
import java.io.IOException;
@@ -125,11 +124,4 @@ public interface RecordSerializer<T extends IOReadableWritable> {
* @return <tt>true</tt> if some data is present
*/
boolean hasData();
-
- /**
- * Instantiates all metrics.
- *
- * @param metrics metric group
- */
- void instantiateMetrics(TaskIOMetricGroup metrics);
}
http://git-wip-us.apache.org/repos/asf/flink/blob/10aae991/flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/serialization/SpanningRecordSerializer.java
----------------------------------------------------------------------
diff --git a/flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/serialization/SpanningRecordSerializer.java b/flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/serialization/SpanningRecordSerializer.java
index efdfaa1..5e6f8e2 100644
--- a/flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/serialization/SpanningRecordSerializer.java
+++ b/flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/serialization/SpanningRecordSerializer.java
@@ -23,7 +23,6 @@ import org.apache.flink.core.memory.DataOutputSerializer;
import org.apache.flink.core.memory.MemorySegment;
import org.apache.flink.runtime.io.network.buffer.Buffer;
import org.apache.flink.runtime.io.network.buffer.BufferBuilder;
-import org.apache.flink.runtime.metrics.groups.TaskIOMetricGroup;
import javax.annotation.Nullable;
@@ -178,8 +177,4 @@ public class SpanningRecordSerializer<T extends IOReadableWritable> implements R
// either data in current target buffer or intermediate buffers
return (targetBuffer != null && !targetBuffer.isEmpty()) || lengthBuffer.hasRemaining() || dataBuffer.hasRemaining();
}
-
- @Override
- public void instantiateMetrics(TaskIOMetricGroup metrics) {
- }
}