You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "mr-brobot (via GitHub)" <gi...@apache.org> on 2023/05/09 17:37:02 UTC
[GitHub] [arrow-rs] mr-brobot opened a new pull request, #4188: feat(object_store): resolve aws region using bucket name
mr-brobot opened a new pull request, #4188:
URL: https://github.com/apache/arrow-rs/pull/4188
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #3213.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
See #3213.
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
Added a new `AmazonS3Builder::with_resolved_region` method that uses the HeadBucket API to infer the bucket region.
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on pull request #4188: Object Store (AWS): Support dynamically resolving S3 bucket region
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #4188:
URL: https://github.com/apache/arrow-rs/pull/4188#issuecomment-1541528807
> but that might not be true forever
I think this is fine, we can always update the tests should this change. I don't think it is worth the added complexity to mock it out, you would end up with more test logic than actual logic :laughing:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on pull request #4188: Object Store (AWS): Support dynamically resolving S3 bucket region
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #4188:
URL: https://github.com/apache/arrow-rs/pull/4188#issuecomment-1541583983
Thank you for working on this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on pull request #4188: Object Store (AWS): Support dynamically resolving S3 bucket region
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #4188:
URL: https://github.com/apache/arrow-rs/pull/4188#issuecomment-1540663262
Really nice find that it returns the header even on permission error 👍
Given this doesn't use anything on the builder, what do you think about making this a free function that takes a bucket name and &ClientOptions and returns the region? This would keep the builder signature slightly more consistent?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #4188: Object Store (AWS): Support dynamically resolving S3 bucket region
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold merged PR #4188:
URL: https://github.com/apache/arrow-rs/pull/4188
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on pull request #4188: Object Store (AWS): Support dynamically resolving S3 bucket region
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #4188:
URL: https://github.com/apache/arrow-rs/pull/4188#issuecomment-1541539838
I took the liberty of pushing https://github.com/apache/arrow-rs/pull/4188/commits/5c5fc070aa9cd914984e5cb658b0427e04c22ca2 to clean the error handling up a little, prior to getting this in
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] mr-brobot commented on pull request #4188: Object Store (AWS): Support dynamically resolving S3 bucket region
Posted by "mr-brobot (via GitHub)" <gi...@apache.org>.
mr-brobot commented on PR #4188:
URL: https://github.com/apache/arrow-rs/pull/4188#issuecomment-1540923134
@tustvold I like that suggestion. Implemented as `aws::resolve_bucket_region`. ✅
I'd like your feedback on the tests too... They hit the S3 HeadBucket API using some bucket names that work today, but that might not be true forever (someone could create a bucket named "please-dont-exist").
This was to show it working in PR, but maybe better to convert to unit tests by creating a private `head_bucket` function with different implementations for test/live?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org