[GitHub] [incubator-inlong] healchow commented on a diff in pull request #3785: [INLONG-3773][Sort-Standalone] Support configurable handler to transform data of Kafka

[GitBox <gi...@apache.org>]

healchow commented on code in PR #3785:
URL: https://github.com/apache/incubator-inlong/pull/3785#discussion_r852589848


##########
inlong-sort-standalone/sort-standalone-source/src/main/java/org/apache/inlong/sort/standalone/sink/elasticsearch/EsSinkContext.java:
##########
@@ -17,13 +17,7 @@
 
 package org.apache.inlong.sort.standalone.sink.elasticsearch;
 
-import java.util.ArrayList;
-import java.util.HashMap;
-import java.util.List;
-import java.util.Map;
-import java.util.concurrent.ConcurrentHashMap;
-import java.util.concurrent.LinkedBlockingQueue;
-import java.util.concurrent.atomic.AtomicLong;
+import com.alibaba.fastjson.JSON;

Review Comment:
   There are too many security risks in this package, could you replace it with the Gson?



##########
inlong-manager/manager-dao/pom.xml:
##########
@@ -57,8 +57,31 @@
                     <artifactId>spring-boot-autoconfigure</artifactId>
                     <groupId>org.springframework.boot</groupId>
                 </exclusion>
+                <exclusion>
+                    <artifactId>com.sun</artifactId>
+                    <groupId>tools</groupId>
+                </exclusion>
+                <exclusion>
+                    <artifactId>com.sun</artifactId>
+                    <groupId>jconsoles</groupId>
+                </exclusion>
             </exclusions>
         </dependency>
+        
+        <dependency>
+            <groupId>com.sun</groupId>
+            <artifactId>tools</artifactId>
+                <version>1.8.0</version>
+                <scope>system</scope>
+                <systemPath>${JAVA_HOME}/lib/tools.jar</systemPath>

Review Comment:
   Can this configuration work in Windows OS?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org