You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2020/09/02 19:08:31 UTC

[GitHub] [trafficserver] bneradt commented on a change in pull request #7157: rc: fixes systemd unit file stopping

bneradt commented on a change in pull request #7157:
URL: https://github.com/apache/trafficserver/pull/7157#discussion_r482319148



##########
File path: rc/trafficserver.service.in
##########
@@ -27,8 +27,8 @@ Restart=on-failure
 RestartSec=5s
 LimitNOFILE=1000000
 ExecStopPost=/bin/sh -c ' \
-        export TM_PIDFILE=$(@exp_bindir@/traffic_layout} 2>/dev/null | grep RUNTIMEDIR | cut -d: -f2)/manager.lock ; \
-        /bin/rm -f $TM_PIDFILE ; \

Review comment:
       Just checking: are we sure we want to remove the -f? -f will return a non-zero return code in the case of a permissions error. If all we care about is that the pid file does not exist after this, regardless of whether it existed before or not, then -f is correct.
   
   Or do we want a non-zero return code if the pid file did not exist? In that case, removing the -f is correct.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org