You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by Vasily Zakharov <vm...@apache.org> on 2008/04/10 19:15:27 UTC
Updating svn:ignore lists
When trying to create a patch in an already-built environment, a lot
of build-generated directories get in the way.
Probably they need to be added to the corresponding SVN ignore lists.
I've created a GERONIMO-3957 for that, and provided patches for trunk,
branches/2.1, branches/2.0 and tags/2.1.0.
I hope it would be useful.
Vasily
Re: Updating svn:ignore lists
Posted by Donald Woods <dw...@apache.org>.
Lets start a discuss thread, since we should be using the same svn props
across all the Geronimo subprojects and need input from Devtools,
gbuilds, tck and others to make sure we don't break anything....
-Donald
Vasily Zakharov wrote:
> Donald,
>
> Thank you for reacting on this issue.
>
> It doesn't seem to me that the issue is my tool, behavior or style,
> but in the general approach to the generated files. The existing SVN
> properties of Geronimo repository shows that in some cases the known
> generated files are added to svn:ignore list to avoid those files
> being tracked by the SVN client, and that looks logical to me.
>
> What I'm talking about is not a major change, but an attempt to create
> a consistent set of properties by updating properties for some
> particular directories. And I can't see how that could impact others,
> as the proposed change affects only particular generated files and
> directories, not any global policy of any kind.
>
> But if you think it's global enough :), sure, I could start a [DISCUSS] thread.
>
> Thanks!
>
> Vasily
>
>
> On Mon, Apr 14, 2008 at 4:33 PM, Donald Woods <dw...@apache.org> wrote:
>> If you're a committer on multiple projects, then you need to update your
>> config file or tool (TortoiseSVN in this case) to handle this, instead of
>> expecting everyone to map their svn usage to your tool's behavior or your
>> style....
>>
>> Any major changes of svn props should be brought up in a discussion thread
>> with [DISCUSS] as the start of the subject for everyone to review and
>> comment upon before applying, since it could impact others expected svn
>> behavior and needs to be documented for future svn additions.
>>
>>
>> -Donald
>>
>>
>>
>>
>> Vasily Zakharov wrote:
>>
>>> Jason, Donald,
>>>
>>> Thanks for your suggestions, I'll surely follow them.
>>>
>>> However, I'm not sure that having things like 'target' or 'build' in
>>> the exclude list is a wise practice in long-term.
>>> So, I think having a consistent approach from the project side is also
>>> a good idea.
>>>
>>> Thanks!
>>>
>>> Vasily
>>>
>>>
>>> On Fri, Apr 11, 2008 at 2:43 PM, Donald Woods <dw...@apache.org> wrote:
>>>
>>>> Here is what I have in my Subversion config file, which I've accumulated
>>>> across Windows and Linux -
>>>>
>>>> global-ignores = .cvsignore ~$* ~*.tmp *.*~ thumbs.db Thumbs.db *.log
>>>> .project .classpath .settings target nohup.out build.txt
>>>>
>>>> Notice the "build.txt", which I have because I like to pipe the build
>> out
>>>> to a file so I can go back to look at any failed steps, like -
>>>> mvn install | tee build.txt
>>>>
>>>> BTW - Please use the other suggested Apache config settings at -
>>>>
>>>>
>>>>
>> http://cwiki.apache.org/GMOxKB/how-do-i-setup-my-svn-client-for-commits.html
>>>> Note: You have to add these into TortoiseSVN and the command line svn
>>>> config file, if you use both....
>>>>
>>>>
>>>> -Donald
>>>>
>>>>
>>>>
>>>>
>>>> Jason Dillon wrote:
>>>>
>>>>
>>>>> Configure your local svn ignores in ~/.subversion/config under the
>>>>>
>>>> 'global-ignores' property.
>>>>
>>>>> --jason
>>>>>
>>>>>
>>>>> On Apr 11, 2008, at 12:47 AM, Vasily Zakharov wrote:
>>>>>
>>>>>
>>>>>
>>>>>> Well, I'm using TortoiseSVN and it always considers those files to
>> be
>>>>>> added to the repository when I'm going to create a patch.
>>>>>> This obstructs a create patch/commit dialog with a lot of unneeded
>>>>>> entries, and increases the working copy scan time.
>>>>>>
>>>>>> In fact, I wouldn't raise this issue if I don't see that many other
>>>>>> 'target' and 'build' directories are put to svn:ignore lists, while
>>>>>> some are not.
>>>>>>
>>>>>> Vasily
>>>>>>
>>>>>>
>>>>>> On Thu, Apr 10, 2008 at 7:18 PM, Jason Warner <ja...@gmail.com>
>> wrote:
>>>>>>
>>>>>>> Hi Vasily,
>>>>>>>
>>>>>>> What do you mean by getting in the way? I've never had issues
>> with
>>>> this.
>>>>
>>>>>>> What behavior are you seeing?
>>>>>>>
>>>>>>> ~Jason Warner
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On Thu, Apr 10, 2008 at 1:15 PM, Vasily Zakharov <vm...@apache.org>
>>>>>>>
>>>> wrote:
>>>>
>>>>>>>
>>>>>>>> When trying to create a patch in an already-built environment, a
>> lot
>>>>>>>> of build-generated directories get in the way.
>>>>>>>> Probably they need to be added to the corresponding SVN ignore
>>>>>>>>
>>>> lists.
>>>>
>>>>>>>> I've created a GERONIMO-3957 for that, and provided patches for
>>>>>>>>
>>>> trunk,
>>>>
>>>>>>>> branches/2.1, branches/2.0 and tags/2.1.0.
>>>>>>>>
>>>>>>>> I hope it would be useful.
>>>>>>>>
>>>>>>>> Vasily
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> ~Jason Warner
>>>>>>>
>>>>>>>
>>>>>
>>>>>
>>>
>
Re: Updating svn:ignore lists
Posted by Vasily Zakharov <vm...@apache.org>.
Donald,
Thank you for reacting on this issue.
It doesn't seem to me that the issue is my tool, behavior or style,
but in the general approach to the generated files. The existing SVN
properties of Geronimo repository shows that in some cases the known
generated files are added to svn:ignore list to avoid those files
being tracked by the SVN client, and that looks logical to me.
What I'm talking about is not a major change, but an attempt to create
a consistent set of properties by updating properties for some
particular directories. And I can't see how that could impact others,
as the proposed change affects only particular generated files and
directories, not any global policy of any kind.
But if you think it's global enough :), sure, I could start a [DISCUSS] thread.
Thanks!
Vasily
On Mon, Apr 14, 2008 at 4:33 PM, Donald Woods <dw...@apache.org> wrote:
> If you're a committer on multiple projects, then you need to update your
> config file or tool (TortoiseSVN in this case) to handle this, instead of
> expecting everyone to map their svn usage to your tool's behavior or your
> style....
>
> Any major changes of svn props should be brought up in a discussion thread
> with [DISCUSS] as the start of the subject for everyone to review and
> comment upon before applying, since it could impact others expected svn
> behavior and needs to be documented for future svn additions.
>
>
> -Donald
>
>
>
>
> Vasily Zakharov wrote:
>
> > Jason, Donald,
> >
> > Thanks for your suggestions, I'll surely follow them.
> >
> > However, I'm not sure that having things like 'target' or 'build' in
> > the exclude list is a wise practice in long-term.
> > So, I think having a consistent approach from the project side is also
> > a good idea.
> >
> > Thanks!
> >
> > Vasily
> >
> >
> > On Fri, Apr 11, 2008 at 2:43 PM, Donald Woods <dw...@apache.org> wrote:
> >
> > > Here is what I have in my Subversion config file, which I've accumulated
> > > across Windows and Linux -
> > >
> > > global-ignores = .cvsignore ~$* ~*.tmp *.*~ thumbs.db Thumbs.db *.log
> > > .project .classpath .settings target nohup.out build.txt
> > >
> > > Notice the "build.txt", which I have because I like to pipe the build
> out
> > > to a file so I can go back to look at any failed steps, like -
> > > mvn install | tee build.txt
> > >
> > > BTW - Please use the other suggested Apache config settings at -
> > >
> > >
> > >
> http://cwiki.apache.org/GMOxKB/how-do-i-setup-my-svn-client-for-commits.html
> > >
> > > Note: You have to add these into TortoiseSVN and the command line svn
> > > config file, if you use both....
> > >
> > >
> > > -Donald
> > >
> > >
> > >
> > >
> > > Jason Dillon wrote:
> > >
> > >
> > > > Configure your local svn ignores in ~/.subversion/config under the
> > > >
> > > 'global-ignores' property.
> > >
> > > > --jason
> > > >
> > > >
> > > > On Apr 11, 2008, at 12:47 AM, Vasily Zakharov wrote:
> > > >
> > > >
> > > >
> > > > > Well, I'm using TortoiseSVN and it always considers those files to
> be
> > > > > added to the repository when I'm going to create a patch.
> > > > > This obstructs a create patch/commit dialog with a lot of unneeded
> > > > > entries, and increases the working copy scan time.
> > > > >
> > > > > In fact, I wouldn't raise this issue if I don't see that many other
> > > > > 'target' and 'build' directories are put to svn:ignore lists, while
> > > > > some are not.
> > > > >
> > > > > Vasily
> > > > >
> > > > >
> > > > > On Thu, Apr 10, 2008 at 7:18 PM, Jason Warner <ja...@gmail.com>
> wrote:
> > > > >
> > > > >
> > > > > > Hi Vasily,
> > > > > >
> > > > > > What do you mean by getting in the way? I've never had issues
> with
> > > > > >
> > > > >
> > > >
> > > this.
> > >
> > > >
> > > > >
> > > > > > What behavior are you seeing?
> > > > > >
> > > > > > ~Jason Warner
> > > > > >
> > > > > >
> > > > > >
> > > > > > On Thu, Apr 10, 2008 at 1:15 PM, Vasily Zakharov <vm...@apache.org>
> > > > > >
> > > > >
> > > >
> > > wrote:
> > >
> > > >
> > > > >
> > > > > >
> > > > > >
> > > > > > > When trying to create a patch in an already-built environment, a
> lot
> > > > > > > of build-generated directories get in the way.
> > > > > > > Probably they need to be added to the corresponding SVN ignore
> > > > > > >
> > > > > >
> > > > >
> > > >
> > > lists.
> > >
> > > >
> > > > >
> > > > > >
> > > > > > > I've created a GERONIMO-3957 for that, and provided patches for
> > > > > > >
> > > > > >
> > > > >
> > > >
> > > trunk,
> > >
> > > >
> > > > >
> > > > > >
> > > > > > > branches/2.1, branches/2.0 and tags/2.1.0.
> > > > > > >
> > > > > > > I hope it would be useful.
> > > > > > >
> > > > > > > Vasily
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > >
> > > > > >
> > > > > > --
> > > > > > ~Jason Warner
> > > > > >
> > > > > >
> > > > >
> > > >
> > > >
> > > >
> > >
> >
> >
>
Re: Updating svn:ignore lists
Posted by Donald Woods <dw...@apache.org>.
If you're a committer on multiple projects, then you need to update your
config file or tool (TortoiseSVN in this case) to handle this, instead
of expecting everyone to map their svn usage to your tool's behavior or
your style....
Any major changes of svn props should be brought up in a discussion
thread with [DISCUSS] as the start of the subject for everyone to review
and comment upon before applying, since it could impact others expected
svn behavior and needs to be documented for future svn additions.
-Donald
Vasily Zakharov wrote:
> Jason, Donald,
>
> Thanks for your suggestions, I'll surely follow them.
>
> However, I'm not sure that having things like 'target' or 'build' in
> the exclude list is a wise practice in long-term.
> So, I think having a consistent approach from the project side is also
> a good idea.
>
> Thanks!
>
> Vasily
>
>
> On Fri, Apr 11, 2008 at 2:43 PM, Donald Woods <dw...@apache.org> wrote:
>> Here is what I have in my Subversion config file, which I've accumulated
>> across Windows and Linux -
>>
>> global-ignores = .cvsignore ~$* ~*.tmp *.*~ thumbs.db Thumbs.db *.log
>> .project .classpath .settings target nohup.out build.txt
>>
>> Notice the "build.txt", which I have because I like to pipe the build out
>> to a file so I can go back to look at any failed steps, like -
>> mvn install | tee build.txt
>>
>> BTW - Please use the other suggested Apache config settings at -
>>
>>
>> http://cwiki.apache.org/GMOxKB/how-do-i-setup-my-svn-client-for-commits.html
>>
>> Note: You have to add these into TortoiseSVN and the command line svn
>> config file, if you use both....
>>
>>
>> -Donald
>>
>>
>>
>>
>> Jason Dillon wrote:
>>
>>> Configure your local svn ignores in ~/.subversion/config under the
>> 'global-ignores' property.
>>> --jason
>>>
>>>
>>> On Apr 11, 2008, at 12:47 AM, Vasily Zakharov wrote:
>>>
>>>
>>>> Well, I'm using TortoiseSVN and it always considers those files to be
>>>> added to the repository when I'm going to create a patch.
>>>> This obstructs a create patch/commit dialog with a lot of unneeded
>>>> entries, and increases the working copy scan time.
>>>>
>>>> In fact, I wouldn't raise this issue if I don't see that many other
>>>> 'target' and 'build' directories are put to svn:ignore lists, while
>>>> some are not.
>>>>
>>>> Vasily
>>>>
>>>>
>>>> On Thu, Apr 10, 2008 at 7:18 PM, Jason Warner <ja...@gmail.com> wrote:
>>>>
>>>>> Hi Vasily,
>>>>>
>>>>> What do you mean by getting in the way? I've never had issues with
>> this.
>>>>> What behavior are you seeing?
>>>>>
>>>>> ~Jason Warner
>>>>>
>>>>>
>>>>>
>>>>> On Thu, Apr 10, 2008 at 1:15 PM, Vasily Zakharov <vm...@apache.org>
>> wrote:
>>>>>
>>>>>> When trying to create a patch in an already-built environment, a lot
>>>>>> of build-generated directories get in the way.
>>>>>> Probably they need to be added to the corresponding SVN ignore
>> lists.
>>>>>> I've created a GERONIMO-3957 for that, and provided patches for
>> trunk,
>>>>>> branches/2.1, branches/2.0 and tags/2.1.0.
>>>>>>
>>>>>> I hope it would be useful.
>>>>>>
>>>>>> Vasily
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> ~Jason Warner
>>>>>
>>>
>>>
>
Re: Updating svn:ignore lists
Posted by Vasily Zakharov <vm...@apache.org>.
Jason, Donald,
Thanks for your suggestions, I'll surely follow them.
However, I'm not sure that having things like 'target' or 'build' in
the exclude list is a wise practice in long-term.
So, I think having a consistent approach from the project side is also
a good idea.
Thanks!
Vasily
On Fri, Apr 11, 2008 at 2:43 PM, Donald Woods <dw...@apache.org> wrote:
> Here is what I have in my Subversion config file, which I've accumulated
> across Windows and Linux -
>
> global-ignores = .cvsignore ~$* ~*.tmp *.*~ thumbs.db Thumbs.db *.log
> .project .classpath .settings target nohup.out build.txt
>
> Notice the "build.txt", which I have because I like to pipe the build out
> to a file so I can go back to look at any failed steps, like -
> mvn install | tee build.txt
>
> BTW - Please use the other suggested Apache config settings at -
>
>
> http://cwiki.apache.org/GMOxKB/how-do-i-setup-my-svn-client-for-commits.html
>
> Note: You have to add these into TortoiseSVN and the command line svn
> config file, if you use both....
>
>
> -Donald
>
>
>
>
> Jason Dillon wrote:
>
> > Configure your local svn ignores in ~/.subversion/config under the
> 'global-ignores' property.
> >
> > --jason
> >
> >
> > On Apr 11, 2008, at 12:47 AM, Vasily Zakharov wrote:
> >
> >
> > > Well, I'm using TortoiseSVN and it always considers those files to be
> > > added to the repository when I'm going to create a patch.
> > > This obstructs a create patch/commit dialog with a lot of unneeded
> > > entries, and increases the working copy scan time.
> > >
> > > In fact, I wouldn't raise this issue if I don't see that many other
> > > 'target' and 'build' directories are put to svn:ignore lists, while
> > > some are not.
> > >
> > > Vasily
> > >
> > >
> > > On Thu, Apr 10, 2008 at 7:18 PM, Jason Warner <ja...@gmail.com> wrote:
> > >
> > > > Hi Vasily,
> > > >
> > > > What do you mean by getting in the way? I've never had issues with
> this.
> > > > What behavior are you seeing?
> > > >
> > > > ~Jason Warner
> > > >
> > > >
> > > >
> > > > On Thu, Apr 10, 2008 at 1:15 PM, Vasily Zakharov <vm...@apache.org>
> wrote:
> > > >
> > > >
> > > > > When trying to create a patch in an already-built environment, a lot
> > > > > of build-generated directories get in the way.
> > > > > Probably they need to be added to the corresponding SVN ignore
> lists.
> > > > >
> > > > > I've created a GERONIMO-3957 for that, and provided patches for
> trunk,
> > > > > branches/2.1, branches/2.0 and tags/2.1.0.
> > > > >
> > > > > I hope it would be useful.
> > > > >
> > > > > Vasily
> > > > >
> > > > >
> > > >
> > > >
> > > >
> > > > --
> > > > ~Jason Warner
> > > >
> > >
> >
> >
> >
>
Re: Updating svn:ignore lists
Posted by Donald Woods <dw...@apache.org>.
Here is what I have in my Subversion config file, which I've accumulated
across Windows and Linux -
global-ignores = .cvsignore ~$* ~*.tmp *.*~ thumbs.db Thumbs.db *.log
.project .classpath .settings target nohup.out build.txt
Notice the "build.txt", which I have because I like to pipe the build
out to a file so I can go back to look at any failed steps, like -
mvn install | tee build.txt
BTW - Please use the other suggested Apache config settings at -
http://cwiki.apache.org/GMOxKB/how-do-i-setup-my-svn-client-for-commits.html
Note: You have to add these into TortoiseSVN and the command line svn
config file, if you use both....
-Donald
Jason Dillon wrote:
> Configure your local svn ignores in ~/.subversion/config under the
> 'global-ignores' property.
>
> --jason
>
>
> On Apr 11, 2008, at 12:47 AM, Vasily Zakharov wrote:
>
>> Well, I'm using TortoiseSVN and it always considers those files to be
>> added to the repository when I'm going to create a patch.
>> This obstructs a create patch/commit dialog with a lot of unneeded
>> entries, and increases the working copy scan time.
>>
>> In fact, I wouldn't raise this issue if I don't see that many other
>> 'target' and 'build' directories are put to svn:ignore lists, while
>> some are not.
>>
>> Vasily
>>
>>
>> On Thu, Apr 10, 2008 at 7:18 PM, Jason Warner <ja...@gmail.com> wrote:
>>> Hi Vasily,
>>>
>>> What do you mean by getting in the way? I've never had issues with
>>> this.
>>> What behavior are you seeing?
>>>
>>> ~Jason Warner
>>>
>>>
>>>
>>> On Thu, Apr 10, 2008 at 1:15 PM, Vasily Zakharov <vm...@apache.org> wrote:
>>>
>>>> When trying to create a patch in an already-built environment, a lot
>>>> of build-generated directories get in the way.
>>>> Probably they need to be added to the corresponding SVN ignore lists.
>>>>
>>>> I've created a GERONIMO-3957 for that, and provided patches for trunk,
>>>> branches/2.1, branches/2.0 and tags/2.1.0.
>>>>
>>>> I hope it would be useful.
>>>>
>>>> Vasily
>>>>
>>>
>>>
>>>
>>> --
>>> ~Jason Warner
>
>
Re: Updating svn:ignore lists
Posted by Jason Dillon <ja...@planet57.com>.
Configure your local svn ignores in ~/.subversion/config under the
'global-ignores' property.
--jason
On Apr 11, 2008, at 12:47 AM, Vasily Zakharov wrote:
> Well, I'm using TortoiseSVN and it always considers those files to be
> added to the repository when I'm going to create a patch.
> This obstructs a create patch/commit dialog with a lot of unneeded
> entries, and increases the working copy scan time.
>
> In fact, I wouldn't raise this issue if I don't see that many other
> 'target' and 'build' directories are put to svn:ignore lists, while
> some are not.
>
> Vasily
>
>
> On Thu, Apr 10, 2008 at 7:18 PM, Jason Warner <ja...@gmail.com>
> wrote:
>> Hi Vasily,
>>
>> What do you mean by getting in the way? I've never had issues with
>> this.
>> What behavior are you seeing?
>>
>> ~Jason Warner
>>
>>
>>
>> On Thu, Apr 10, 2008 at 1:15 PM, Vasily Zakharov <vm...@apache.org>
>> wrote:
>>
>>> When trying to create a patch in an already-built environment, a lot
>>> of build-generated directories get in the way.
>>> Probably they need to be added to the corresponding SVN ignore
>>> lists.
>>>
>>> I've created a GERONIMO-3957 for that, and provided patches for
>>> trunk,
>>> branches/2.1, branches/2.0 and tags/2.1.0.
>>>
>>> I hope it would be useful.
>>>
>>> Vasily
>>>
>>
>>
>>
>> --
>> ~Jason Warner
Re: Updating svn:ignore lists
Posted by Jason Warner <ja...@gmail.com>.
On Thu, Apr 10, 2008 at 2:03 PM, Vasily Zakharov <vm...@apache.org> wrote:
> No, I don't think is a Tortoise problem indeed.
> It just proposes to add to the patch all new (not added to SVN) files
> it sees in the working directory unless they're put to svn:ignore
> lists.
> Looks pretty logical and intuitive to me. :)
Oh, ok. Yeah. I see that now. It is pretty nice, actually. My mistake.
>
>
> Anyway, I'm not crying in despair :), I just see that in some cases
> svn:ignore lists are properly maintained and include all the generated
> directories, and in some cases they're not, and I think that it
> probably worths to be consistent in this matter. :)
>
Sounds good to me. Thanks for clearing up my confusion!
>
> Vasily
>
>
> On Thu, Apr 10, 2008 at 7:55 PM, Jason Warner <ja...@gmail.com> wrote:
> > Alright. I was just curious why you were seeing an issue I wasn't. Now
> > that I see you're using TortoiseSVN it all becomes clear ;) I liked
> > tortoiseSVN's interface, it just has little bugs here and there that got
> on
> > my nerves too much. I'm inclined to think the issue is in how
> tortoiseSVN
> > is handling creating patches. I'm not opposed to the change, though.
> Just
> > curious, is all. Thanks for the info!
> >
> > ~Jason Warner
> >
> >
> >
> > On Thu, Apr 10, 2008 at 1:47 PM, Vasily Zakharov <vm...@apache.org> wrote:
> > > Well, I'm using TortoiseSVN and it always considers those files to be
> > > added to the repository when I'm going to create a patch.
> > > This obstructs a create patch/commit dialog with a lot of unneeded
> > > entries, and increases the working copy scan time.
> > >
> > > In fact, I wouldn't raise this issue if I don't see that many other
> > > 'target' and 'build' directories are put to svn:ignore lists, while
> > > some are not.
> > >
> > > Vasily
> > >
> > >
> > >
> > >
> > >
> > > On Thu, Apr 10, 2008 at 7:18 PM, Jason Warner <ja...@gmail.com>
> wrote:
> > > > Hi Vasily,
> > > >
> > > > What do you mean by getting in the way? I've never had issues with
> > this.
> > > > What behavior are you seeing?
> > > >
> > > > ~Jason Warner
> > > >
> > > >
> > > >
> > > > On Thu, Apr 10, 2008 at 1:15 PM, Vasily Zakharov <vm...@apache.org>
> wrote:
> > > >
> > > > > When trying to create a patch in an already-built environment, a
> lot
> > > > > of build-generated directories get in the way.
> > > > > Probably they need to be added to the corresponding SVN ignore
> lists.
> > > > >
> > > > > I've created a GERONIMO-3957 for that, and provided patches for
> trunk,
> > > > > branches/2.1, branches/2.0 and tags/2.1.0.
> > > > >
> > > > > I hope it would be useful.
> > > > >
> > > > > Vasily
> > > > >
> > > >
> > > >
> > > >
> > > > --
> > > > ~Jason Warner
> > >
> >
> >
> >
> > --
> > ~Jason Warner
>
--
~Jason Warner
Re: Updating svn:ignore lists
Posted by Vasily Zakharov <vm...@apache.org>.
No, I don't think is a Tortoise problem indeed.
It just proposes to add to the patch all new (not added to SVN) files
it sees in the working directory unless they're put to svn:ignore
lists.
Looks pretty logical and intuitive to me. :)
Anyway, I'm not crying in despair :), I just see that in some cases
svn:ignore lists are properly maintained and include all the generated
directories, and in some cases they're not, and I think that it
probably worths to be consistent in this matter. :)
Vasily
On Thu, Apr 10, 2008 at 7:55 PM, Jason Warner <ja...@gmail.com> wrote:
> Alright. I was just curious why you were seeing an issue I wasn't. Now
> that I see you're using TortoiseSVN it all becomes clear ;) I liked
> tortoiseSVN's interface, it just has little bugs here and there that got on
> my nerves too much. I'm inclined to think the issue is in how tortoiseSVN
> is handling creating patches. I'm not opposed to the change, though. Just
> curious, is all. Thanks for the info!
>
> ~Jason Warner
>
>
>
> On Thu, Apr 10, 2008 at 1:47 PM, Vasily Zakharov <vm...@apache.org> wrote:
> > Well, I'm using TortoiseSVN and it always considers those files to be
> > added to the repository when I'm going to create a patch.
> > This obstructs a create patch/commit dialog with a lot of unneeded
> > entries, and increases the working copy scan time.
> >
> > In fact, I wouldn't raise this issue if I don't see that many other
> > 'target' and 'build' directories are put to svn:ignore lists, while
> > some are not.
> >
> > Vasily
> >
> >
> >
> >
> >
> > On Thu, Apr 10, 2008 at 7:18 PM, Jason Warner <ja...@gmail.com> wrote:
> > > Hi Vasily,
> > >
> > > What do you mean by getting in the way? I've never had issues with
> this.
> > > What behavior are you seeing?
> > >
> > > ~Jason Warner
> > >
> > >
> > >
> > > On Thu, Apr 10, 2008 at 1:15 PM, Vasily Zakharov <vm...@apache.org> wrote:
> > >
> > > > When trying to create a patch in an already-built environment, a lot
> > > > of build-generated directories get in the way.
> > > > Probably they need to be added to the corresponding SVN ignore lists.
> > > >
> > > > I've created a GERONIMO-3957 for that, and provided patches for trunk,
> > > > branches/2.1, branches/2.0 and tags/2.1.0.
> > > >
> > > > I hope it would be useful.
> > > >
> > > > Vasily
> > > >
> > >
> > >
> > >
> > > --
> > > ~Jason Warner
> >
>
>
>
> --
> ~Jason Warner
Re: Updating svn:ignore lists
Posted by Jason Warner <ja...@gmail.com>.
Alright. I was just curious why you were seeing an issue I wasn't. Now
that I see you're using TortoiseSVN it all becomes clear ;) I liked
tortoiseSVN's interface, it just has little bugs here and there that got on
my nerves too much. I'm inclined to think the issue is in how tortoiseSVN
is handling creating patches. I'm not opposed to the change, though. Just
curious, is all. Thanks for the info!
~Jason Warner
On Thu, Apr 10, 2008 at 1:47 PM, Vasily Zakharov <vm...@apache.org> wrote:
> Well, I'm using TortoiseSVN and it always considers those files to be
> added to the repository when I'm going to create a patch.
> This obstructs a create patch/commit dialog with a lot of unneeded
> entries, and increases the working copy scan time.
>
> In fact, I wouldn't raise this issue if I don't see that many other
> 'target' and 'build' directories are put to svn:ignore lists, while
> some are not.
>
> Vasily
>
>
> On Thu, Apr 10, 2008 at 7:18 PM, Jason Warner <ja...@gmail.com> wrote:
> > Hi Vasily,
> >
> > What do you mean by getting in the way? I've never had issues with
> this.
> > What behavior are you seeing?
> >
> > ~Jason Warner
> >
> >
> >
> > On Thu, Apr 10, 2008 at 1:15 PM, Vasily Zakharov <vm...@apache.org> wrote:
> >
> > > When trying to create a patch in an already-built environment, a lot
> > > of build-generated directories get in the way.
> > > Probably they need to be added to the corresponding SVN ignore lists.
> > >
> > > I've created a GERONIMO-3957 for that, and provided patches for trunk,
> > > branches/2.1, branches/2.0 and tags/2.1.0.
> > >
> > > I hope it would be useful.
> > >
> > > Vasily
> > >
> >
> >
> >
> > --
> > ~Jason Warner
>
--
~Jason Warner
Re: Updating svn:ignore lists
Posted by Vasily Zakharov <vm...@apache.org>.
Well, I'm using TortoiseSVN and it always considers those files to be
added to the repository when I'm going to create a patch.
This obstructs a create patch/commit dialog with a lot of unneeded
entries, and increases the working copy scan time.
In fact, I wouldn't raise this issue if I don't see that many other
'target' and 'build' directories are put to svn:ignore lists, while
some are not.
Vasily
On Thu, Apr 10, 2008 at 7:18 PM, Jason Warner <ja...@gmail.com> wrote:
> Hi Vasily,
>
> What do you mean by getting in the way? I've never had issues with this.
> What behavior are you seeing?
>
> ~Jason Warner
>
>
>
> On Thu, Apr 10, 2008 at 1:15 PM, Vasily Zakharov <vm...@apache.org> wrote:
>
> > When trying to create a patch in an already-built environment, a lot
> > of build-generated directories get in the way.
> > Probably they need to be added to the corresponding SVN ignore lists.
> >
> > I've created a GERONIMO-3957 for that, and provided patches for trunk,
> > branches/2.1, branches/2.0 and tags/2.1.0.
> >
> > I hope it would be useful.
> >
> > Vasily
> >
>
>
>
> --
> ~Jason Warner
Re: Updating svn:ignore lists
Posted by Jason Warner <ja...@gmail.com>.
Hi Vasily,
What do you mean by getting in the way? I've never had issues with this.
What behavior are you seeing?
~Jason Warner
On Thu, Apr 10, 2008 at 1:15 PM, Vasily Zakharov <vm...@apache.org> wrote:
> When trying to create a patch in an already-built environment, a lot
> of build-generated directories get in the way.
> Probably they need to be added to the corresponding SVN ignore lists.
>
> I've created a GERONIMO-3957 for that, and provided patches for trunk,
> branches/2.1, branches/2.0 and tags/2.1.0.
>
> I hope it would be useful.
>
> Vasily
>
--
~Jason Warner