You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by GitBox <gi...@apache.org> on 2019/10/04 21:39:02 UTC

[GitHub] [qpid-dispatch] bhardesty commented on a change in pull request #581: DISPATCH-1442 - Added annotation field to the router entity.

bhardesty commented on a change in pull request #581: DISPATCH-1442 - Added annotation field to the router entity.
URL: https://github.com/apache/qpid-dispatch/pull/581#discussion_r331695501
 
 

 ##########
 File path: python/qpid_dispatch/management/qdrouter.json
 ##########
 @@ -493,6 +493,12 @@
                     "create": true,
                     "required": false,
                     "default": "balanced"
+                },
+                "annotation": {
+                    "type": "string",
+                    "description": "Annotation text for this router, to be used by user or orchestration layers.",
 
 Review comment:
   It doesn't seem clear from the description why someone would add an annotation to a router. Is it just a free-form description of the router?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org