[jira] Commented: (THRIFT-321) THRIFT-303 broke EqualityTest

["David Reiss (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12671517#action_12671517 ] 

David Reiss commented on THRIFT-321:
------------------------------------

I disagree.  I think it is really valuable to have a test of every possible combination of field type (object/primitive/array), optional-required-ness, isset, and nullness.  I wouldn't have been confident in my implementation of .equals() without it.  This patch updates the test (a three-line change to the Python and regenerating the Java) and updates ToStringTest, which was broken for the same reason.

> THRIFT-303 broke EqualityTest
> -----------------------------
>
>                 Key: THRIFT-321
>                 URL: https://issues.apache.org/jira/browse/THRIFT-321
>             Project: Thrift
>          Issue Type: Bug
>          Components: Library (Java)
>            Reporter: Bryan Duxbury
>            Assignee: Bryan Duxbury
>         Attachments: 0001-THRIFT-321.-java-Fix-broken-tests-in-the-wake-of-r7.patch
>
>
> It looks like I forgot to solve the EqualityTest issues before committing THRIFT-303. This means the Java test suite won't compile.
> Currently, the test is the result of a python script. This seems complex and gratuitous. I think we should replace it with a much shorter, more specific test that isn't generated.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.