[jira] Commented: (FELIX-2277) Allow the user to select display language

["Felix Meschberger (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FELIX-2277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12889653#action_12889653 ] 

Felix Meschberger commented on FELIX-2277:
------------------------------------------

Looks good with the following comments:

(1) I would change line 626 of the patched AbstractWebConsolePlugin file to
                             if (null != langMap && !langMap.isEmpty())
     thus to not render the flag "button" if there is no flag to render

(2) How about caching the flags map in the OsgiManager class. The contents of the map is rendered on each request, thus the entries scanned on each request. On the other hand the entries only change when the bundle is resolved and the OsgiManager class recreated any way. WDYT ?

Other than that,I am all for applying the patch. Thanks.

> Allow the user to select display language
> -----------------------------------------
>
>                 Key: FELIX-2277
>                 URL: https://issues.apache.org/jira/browse/FELIX-2277
>             Project: Felix
>          Issue Type: Improvement
>          Components: Web Console
>    Affects Versions: webconsole-3.0.0
>            Reporter: Valentin Valchev
>            Assignee: Valentin Valchev
>            Priority: Minor
>         Attachments: langselect.zip, locale-select.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.