svn commit: r1734724 - /jmeter/trunk/src/core/org/apache/jmeter/save/converters/SampleSaveConfigurationConverter.java

[se...@apache.org]

Author: sebb
Date: Sat Mar 12 18:45:40 2016
New Revision: 1734724

URL: http://svn.apache.org/viewvc?rev=1734724&view=rev
Log:
Docs

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/save/converters/SampleSaveConfigurationConverter.java

Modified: jmeter/trunk/src/core/org/apache/jmeter/save/converters/SampleSaveConfigurationConverter.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/save/converters/SampleSaveConfigurationConverter.java?rev=1734724&r1=1734723&r2=1734724&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/save/converters/SampleSaveConfigurationConverter.java (original)
+++ jmeter/trunk/src/core/org/apache/jmeter/save/converters/SampleSaveConfigurationConverter.java Sat Mar 12 18:45:40 2016
@@ -82,6 +82,7 @@ public class SampleSaveConfigurationConv
                 String fieldName) {
             if (SampleSaveConfiguration.class != definedIn) { return true; }
             // These are new fields; not saved unless true
+            // This list MUST agree with the list in the marshall() method below
             if (fieldName.equals(NODE_BYTES)) { return false; }
             if (fieldName.equals(NODE_URL)) { return false; }
             if (fieldName.equals(NODE_FILENAME)) { return false; }
@@ -125,7 +126,8 @@ public class SampleSaveConfigurationConv
 
         SampleSaveConfiguration prop = (SampleSaveConfiguration) obj;
 
-        // Save the new fields - but only if they are not the default
+        // Save the new fields - but only if they are true
+        // This list MUST agree with the list in MyWrapper#shouldSerializeMember()
         createNode(writer,prop.saveBytes(),NODE_BYTES);
         createNode(writer,prop.saveUrl(),NODE_URL);
         createNode(writer,prop.saveFileName(),NODE_FILENAME);
@@ -136,7 +138,7 @@ public class SampleSaveConfigurationConv
         createNode(writer, prop.saveConnectTime(), NODE_CONNECT_TIME);
     }
 
-    // Helper method to simplify marshall routine
+    // Helper method to simplify marshall routine. Save iff true.
     private void createNode(HierarchicalStreamWriter writer, boolean save, String node) {
         if (!save) {
             return;