You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "westonpace (via GitHub)" <gi...@apache.org> on 2023/05/31 06:55:11 UTC
[GitHub] [arrow] westonpace opened a new pull request, #35834: GH-35820: [C++][CI] EnsureAlignment.Buffer fails on test-build-vcpkg-win
westonpace opened a new pull request, #35834:
URL: https://github.com/apache/arrow/pull/35834
### Rationale for this change
There is a bug in the version of mimalloc that we currently vendor (2.0.6) which is https://github.com/microsoft/mimalloc/issues/700
This bug causes aligned allocations to be improperly aligned if the requested alignment is greater than 128 and less than 1024. The allocations are always given 128 byte alignment. This also only seems to affect release mode.
In practice, we never actually request alignment greater than 128 bytes. However, there was a test case that was requesting alignment of 256 bytes. Since this bug only affects a test case I'm not sure it warrants upgrading the mimalloc version (though we might want to do so at some point for other reasons).
One could argue that memory pool is a part of our public interface and so this is a bug in a public method (the ability to allocate an aligned buffer) though users are welcome to use a newer version of mimalloc on their own.
### What changes are included in this PR?
The test is modified to request 128 byte alignment instead of 256 byte alignment
### Are these changes tested?
I was able to reproduce the issue on my Linux system by compiling in release mode and using mimalloc. I verified that upgrading mimalloc to 2.1.0 prevented the bug. The fix itself is a test case and so the change is tested.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35834: GH-35820: [C++][CI] EnsureAlignment.Buffer fails on test-build-vcpkg-win
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35834:
URL: https://github.com/apache/arrow/pull/35834#issuecomment-1569598685
:warning: GitHub issue #35820 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou merged pull request #35834: GH-35820: [C++][CI] EnsureAlignment.Buffer fails on test-build-vcpkg-win
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou merged PR #35834:
URL: https://github.com/apache/arrow/pull/35834
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on pull request #35834: GH-35820: [C++][CI] EnsureAlignment.Buffer fails on test-build-vcpkg-win
Posted by "westonpace (via GitHub)" <gi...@apache.org>.
westonpace commented on PR #35834:
URL: https://github.com/apache/arrow/pull/35834#issuecomment-1569601061
Apologies for the over-zealous labeling. I was originally rebased off the maint branch. I've adjusted to the main branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on pull request #35834: GH-35820: [C++][CI] EnsureAlignment.Buffer fails on test-build-vcpkg-win
Posted by "westonpace (via GitHub)" <gi...@apache.org>.
westonpace commented on PR #35834:
URL: https://github.com/apache/arrow/pull/35834#issuecomment-1569602001
@github-actions crossbow submit test-build-vcpkg-win
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35834: GH-35820: [C++][CI] EnsureAlignment.Buffer fails on test-build-vcpkg-win
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35834:
URL: https://github.com/apache/arrow/pull/35834#issuecomment-1569605046
Revision: 3774325b0d68d48c9ef6ebf460be1271cdfd2740
Submitted crossbow builds: [ursacomputing/crossbow @ actions-f7be1360b7](https://github.com/ursacomputing/crossbow/branches/all?query=actions-f7be1360b7)
|Task|Status|
|----|------|
|test-build-vcpkg-win|[](https://github.com/ursacomputing/crossbow/actions/runs/5129827075/jobs/9227869231)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35834: GH-35820: [C++][CI] EnsureAlignment.Buffer fails on test-build-vcpkg-win
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35834:
URL: https://github.com/apache/arrow/pull/35834#issuecomment-1571187271
Benchmark runs are scheduled for baseline = 89b1ebe2031dc071c4cedb6e289c02c39e0a4c3e and contender = 95df6cc045d98b5163202e2ac5dec96b50a5acd2. 95df6cc045d98b5163202e2ac5dec96b50a5acd2 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/853f31d79f6c451ea833127708d93d0f...bc7a9c96b9714d99ab1c2e5caedac30e/)
[Finished :arrow_down:0.47% :arrow_up:0.03%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/103fecc9fb56420d8ee66e04634693f9...1cab654f497249d2b9e8d3732e1443b1/)
[Finished :arrow_down:1.95% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/5512eefa58384f9f8ddaf60b27326e56...883eea503c5d4752a3c2ca9e1fcb7e03/)
[Finished :arrow_down:0.51% :arrow_up:0.06%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/af84ed7e34a8436ab70fbdcb322ae87a...86db52390d894bb8bc16331ebda83ae9/)
Buildkite builds:
[Finished] [`95df6cc0` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2956)
[Finished] [`95df6cc0` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2992)
[Finished] [`95df6cc0` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2957)
[Finished] [`95df6cc0` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2982)
[Finished] [`89b1ebe2` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2955)
[Finished] [`89b1ebe2` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2991)
[Finished] [`89b1ebe2` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2956)
[Finished] [`89b1ebe2` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2981)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35834: GH-35820: [C++][CI] EnsureAlignment.Buffer fails on test-build-vcpkg-win
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35834:
URL: https://github.com/apache/arrow/pull/35834#issuecomment-1569598714
:warning: GitHub issue #35820 **has no components**, please add labels for components.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org