[GitHub] [netbeans] JaroslavTulach commented on pull request #3744: Build with JDK-11 in all Travis jobs

[GitBox <gi...@apache.org>]

JaroslavTulach commented on pull request #3744:
URL: https://github.com/apache/netbeans/pull/3744#issuecomment-1064775267


   > Can we not consolidate on one method of downloading a JDK in this? 
   
   If one trusts that the URL remains persistent, downloading from a URL seems acceptable to me. I have decided to trust this JDK provider in my projects. Moreover this primitive technique is portable across CI types - it shall work everywhere `curl` is installed.
   
   > `install-jdk.sh` should also be in the path and not need downloading itself, although that also may not be the best option. 
   
   I've never used it myself. Neither inside Travis, neither locally (e.g. I cannot test the behavior). The PR is however open for edits from maintainers, if users of `install-jdk.sh` want to step in.
   
   > _A_ JDK 11 should also be installed already too.
   
   I wanted to avoid modifying the behavior of the Travis scripts. For example by accidentally switching to JDK11 for testing. Downloading a JDK into temporary directory and using it only in `ant.sh` guarantees no other part of the scripts is going to be influenced.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists