You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "stack (JIRA)" <ji...@apache.org> on 2009/10/02 06:22:23 UTC

[jira] Updated: (HBASE-1831) Scanning API must be reworked to allow for fully functional Filters client-side

     [ https://issues.apache.org/jira/browse/HBASE-1831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-1831:
-------------------------

    Attachment: 1831-v4.patch

Adds two ugly tests.  One under filter that puts up three regions and then checks at the Region level that filters are doing right thing (Why can't i instantiate an HRegionServer and test from its interface -- its currently way too hard to put one of these up... requires there be a master.. .it shouldn't).  Other test if ugly from client side.  Splits table then makes sure RowFilter is returning right results around the row boundary.  I can assert counts but I can't assert that only a subset of regions are being accessed with asserts.  To do the latter, I added logging and it required eyeballing but you can see in the logs that yes we do not go to next region if filter says we're done.

A few tests seem to be failing.... Looking into it.

> Scanning API must be reworked to allow for fully functional Filters client-side
> -------------------------------------------------------------------------------
>
>                 Key: HBASE-1831
>                 URL: https://issues.apache.org/jira/browse/HBASE-1831
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.20.0
>            Reporter: Jonathan Gray
>            Priority: Critical
>             Fix For: 0.20.1, 0.21.0
>
>         Attachments: 1831-v2.patch, 1831-v3.patch, 1831-v4.patch, 1831.patch
>
>
> Right now, a client replays part of the Filter locally by calling filterRowKey() and filterAllRemaining() to determine whether it should continue to the next region.
> A number of new filters rely on filterKeyValue() and other calls to alter state.  It's also a false assumption that all rows/keys affecting a filter returning true for FAR will be seen client-side (what about those that failed the filter).
> This issue is about dealing with Filters properly from the client-side.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.