You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by edparsons <gi...@git.apache.org> on 2015/12/28 11:21:25 UTC
[GitHub] cordova-plugin-network-information pull request: Adding cell type ...
GitHub user edparsons opened a pull request:
https://github.com/apache/cordova-plugin-network-information/pull/36
Adding cell type to iOS7 and greater
Using CoreTelephony and currentRadioAccessTechnology, this add the ability to iOS developer to see the radio type (2g,3g,4g) so they can use it in both android and iOS applications.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/edparsons/cordova-plugin-network-information patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-network-information/pull/36.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #36
----
commit 791d828fd4a66feb143cf1b71a99cbcb2c132294
Author: edparsons <ed...@hotmail.com>
Date: 2015-12-28T09:20:21Z
Adding CT radio information
commit 3bf19c4c02ccd762eef069a0eae54d7abbe846a9
Author: edparsons <ed...@hotmail.com>
Date: 2015-12-28T10:18:01Z
Adding notification for CT radio information
commit 6ddd34aa4a18e8d4d12af5bf57c9047fc47be49f
Author: edparsons <ed...@hotmail.com>
Date: 2015-12-28T10:19:00Z
Adding CoreTelephony to plugin.xml
commit 3968f2069dfc858244640215046b09649d8b2eb4
Author: edparsons <ed...@hotmail.com>
Date: 2015-12-28T10:19:45Z
Updating readme.md
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-network-information pull request: Adding cell type ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-network-information/pull/36
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-network-information pull request: Adding cell type ...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-network-information/pull/36#issuecomment-169137886
lgtm!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-network-information pull request: Adding cell type ...
Posted by edparsons <gi...@git.apache.org>.
Github user edparsons commented on the pull request:
https://github.com/apache/cordova-plugin-network-information/pull/36#issuecomment-169509389
Great, ok Jesse what are the next steps to getting this merged in?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org