You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by khalidhuseynov <gi...@git.apache.org> on 2017/07/20 17:17:15 UTC
[GitHub] zeppelin pull request #2499: [ZEPPELIN-2801] fix adding unnecessary new line...
GitHub user khalidhuseynov opened a pull request:
https://github.com/apache/zeppelin/pull/2499
[ZEPPELIN-2801] fix adding unnecessary new lines in Jupyter to Zeppelin note converter
### What is this PR for?
Fixes the issue of having doubled new lines between lines when converting Jupyter notes into Zeppelin note.
### What type of PR is it?
Bug Fix
### Todos
* [x] - remove unnecessary `\n` line separator
### What is the Jira issue?
[ZEPPELIN-2801](https://issues.apache.org/jira/browse/ZEPPELIN-2801)
### How should this be tested?
1. prepare sample jupyter note
2. run `java -cp zeppelin-jupyter/target/zeppelin-jupyter-0.8.0-SNAPSHOT.jar org.apache.zeppelin.jupyter.JupyterUtil -i path/To/*.ipynb`, should produce `note.json`
3. import `note.json` into Zeppelin, shouldn't have doubled spaces
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/khalidhuseynov/zeppelin fix/ZEPPELIN-2801
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2499.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2499
----
commit 9af495930561441111c4de5d324c05ee1c6a1e5e
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2017-07-20T17:07:43Z
change lineseparator to empty string
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2499: [ZEPPELIN-2801] fix adding unnecessary new line...
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov closed the pull request at:
https://github.com/apache/zeppelin/pull/2499
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2499: [ZEPPELIN-2801] fix adding unnecessary new lines in Ju...
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/2499
/cc @jongyoul to help review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2499: [ZEPPELIN-2801] fix adding unnecessary new line...
Posted by khalidhuseynov <gi...@git.apache.org>.
GitHub user khalidhuseynov reopened a pull request:
https://github.com/apache/zeppelin/pull/2499
[ZEPPELIN-2801] fix adding unnecessary new lines in Jupyter to Zeppelin note converter
### What is this PR for?
Fixes the issue of having doubled new lines between lines when converting Jupyter notes into Zeppelin note.
### What type of PR is it?
Bug Fix
### Todos
* [x] - remove unnecessary `\n` line separator
### What is the Jira issue?
[ZEPPELIN-2801](https://issues.apache.org/jira/browse/ZEPPELIN-2801)
### How should this be tested?
1. prepare sample jupyter note
2. run `java -cp zeppelin-jupyter/target/zeppelin-jupyter-0.8.0-SNAPSHOT.jar org.apache.zeppelin.jupyter.JupyterUtil -i path/To/*.ipynb`, should produce `note.json`
3. import `note.json` into Zeppelin, shouldn't have doubled spaces
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/khalidhuseynov/zeppelin fix/ZEPPELIN-2801
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2499.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2499
----
commit 9af495930561441111c4de5d324c05ee1c6a1e5e
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2017-07-20T17:07:43Z
change lineseparator to empty string
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2499: [ZEPPELIN-2801] fix adding unnecessary new line...
Posted by khalidhuseynov <gi...@git.apache.org>.
GitHub user khalidhuseynov reopened a pull request:
https://github.com/apache/zeppelin/pull/2499
[ZEPPELIN-2801] fix adding unnecessary new lines in Jupyter to Zeppelin note converter
### What is this PR for?
Fixes the issue of having doubled new lines between lines when converting Jupyter notes into Zeppelin note.
### What type of PR is it?
Bug Fix
### Todos
* [x] - remove unnecessary `\n` line separator
### What is the Jira issue?
[ZEPPELIN-2801](https://issues.apache.org/jira/browse/ZEPPELIN-2801)
### How should this be tested?
1. prepare sample jupyter note
2. run `java -cp zeppelin-jupyter/target/zeppelin-jupyter-0.8.0-SNAPSHOT.jar org.apache.zeppelin.jupyter.JupyterUtil -i path/To/*.ipynb`, should produce `note.json`
3. import `note.json` into Zeppelin, shouldn't have doubled spaces
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/khalidhuseynov/zeppelin fix/ZEPPELIN-2801
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2499.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2499
----
commit 9af495930561441111c4de5d324c05ee1c6a1e5e
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2017-07-20T17:07:43Z
change lineseparator to empty string
commit 039a51db3c884d794fc65708254c33b0ac25c75c
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2017-07-23T08:21:31Z
add verification for end of line
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2499: [ZEPPELIN-2801] fix adding unnecessary new line...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2499
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2499: [ZEPPELIN-2801] fix adding unnecessary new lines in Ju...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2499
Thanks. I didn't know jupyter text already has new line. :-) LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2499: [ZEPPELIN-2801] fix adding unnecessary new line...
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov closed the pull request at:
https://github.com/apache/zeppelin/pull/2499
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2499: [ZEPPELIN-2801] fix adding unnecessary new lines in Ju...
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/2499
thanks for checking, added verification step as well and tested with most of notes in https://github.com/jakevdp/PythonDataScienceHandbook. will be merging if no more discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2499: [ZEPPELIN-2801] fix adding unnecessary new lines in Ju...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2499
Looks better
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---