You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "anhpngt (via GitHub)" <gi...@apache.org> on 2023/07/10 15:09:41 UTC

[GitHub] [camel-k] anhpngt opened a new pull request, #4557: fix(#4556): disable creating k8s client in output mode

anhpngt opened a new pull request, #4557:
URL: https://github.com/apache/camel-k/pull/4557

   <!-- Description -->
   
   Fixes: #4556 4556
   
   
   <!--
   Enter your extended release note in the below block. If the PR requires
   additional action from users switching to the new release, include the string
   "action required". If no release note is required, write "NONE". 
   
   You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
   the text is added to the right section of the release notes. 
   -->
   
   **Release Note**
   ```release-note
   NONE
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] anhpngt commented on pull request #4557: fix(#4556): disable creating k8s client in output mode

Posted by "anhpngt (via GitHub)" <gi...@apache.org>.
anhpngt commented on PR #4557:
URL: https://github.com/apache/camel-k/pull/4557#issuecomment-1630775783

   Thank you for the feedback. I think only `run` and `bind` are affected by this bug. `promote` cannot be run without an actual operator, so I don't think we can do anything about it. Let me fix for `bind` and have the unit tests ready.
   
   There are other offline commands, `version` and `help`, but they are working fine.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] github-actions[bot] commented on pull request #4557: fix(#4556): disable creating k8s client in output mode

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #4557:
URL: https://github.com/apache/camel-k/pull/4557#issuecomment-1632223922

   :camel: **Thank you for contributing!**
   
   Code Coverage Report :heavy_check_mark: - Coverage unchanged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] squakez merged pull request #4557: fix(#4556): disable creating k8s client in output mode

Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez merged PR #4557:
URL: https://github.com/apache/camel-k/pull/4557


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] anhpngt commented on pull request #4557: fix(#4556): disable creating k8s client in output mode

Posted by "anhpngt (via GitHub)" <gi...@apache.org>.
anhpngt commented on PR #4557:
URL: https://github.com/apache/camel-k/pull/4557#issuecomment-1632220101

   hi @squakez, I updated the fix for `bind` and added unit tests for both commands. I tried running the unit test without the fix, it correctly showed the errors now
   
   ```sh
   $ go test -run TestBindOutputWithoutKubernetesCluster
   --- FAIL: TestBindOutputWithoutKubernetesCluster (0.00s)
       bind_test.go:261: 
                   Error Trace:    /home/anhpngt/apache/camel-k/pkg/cmd/bind_test.go:261
                   Error:          Received unexpected error:
                                   invalid configuration: no configuration has been provided, try setting KUBERNETES_MASTER environment variable
                   Test:           TestBindOutputWithoutKubernetesCluster
   FAIL
   exit status 1
   FAIL    github.com/apache/camel-k/v2/pkg/cmd    0.024s
   
   $ go test -run TestRunOutputWithoutKubernetesCluster
   --- FAIL: TestRunOutputWithoutKubernetesCluster (0.00s)
       run_test.go:830: 
                   Error Trace:    /home/anhpngt/apache/camel-k/pkg/cmd/run_test.go:830
                   Error:          Received unexpected error:
                                   invalid configuration: no configuration has been provided, try setting KUBERNETES_MASTER environment variable
                   Test:           TestRunOutputWithoutKubernetesCluster
   FAIL
   exit status 1
   FAIL    github.com/apache/camel-k/v2/pkg/cmd    0.026s
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org