You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tamas Mate (Code Review)" <ge...@cloudera.org> on 2023/02/27 08:31:51 UTC
[native-toolchain-CR] IMPALA-11949: Add AVRO C++ 1.11.1 version
Tamas Mate has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19546
Change subject: IMPALA-11949: Add AVRO C++ 1.11.1 version
......................................................................
IMPALA-11949: Add AVRO C++ 1.11.1 version
This patch adds a new AVRO version 1.11.1 and new build files for AVRO
C++. Until the integration is finished, for backward compatibility, both
AVRO C and AVRO C++ will be part of the toolchain.
The upgrade is necessary to support logical types, which is required
for Iceberg DECIMAL types. The AVRO C library has not been meaningfully
developed for 3 years now and it does not support logical types,
meanwhile the C++ library is still under development and supports the
necessary types.
Change-Id: I307247cdf19ea8b9a97248624111bdaa05dd8496
---
M buildall.sh
A source/avro/avro-1.11.1-patches/0001-fix-cpp-build-error.patch
A source/avro/build-cpp.sh
3 files changed, 683 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/46/19546/1
--
To view, visit http://gerrit.cloudera.org:8080/19546
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I307247cdf19ea8b9a97248624111bdaa05dd8496
Gerrit-Change-Number: 19546
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
[native-toolchain-CR] IMPALA-11949: Add AVRO C++ 1.11.1 version
Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19546 )
Change subject: IMPALA-11949: Add AVRO C++ 1.11.1 version
......................................................................
Patch Set 1: Verified+1
Already tested this build, adding verified.
--
To view, visit http://gerrit.cloudera.org:8080/19546
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I307247cdf19ea8b9a97248624111bdaa05dd8496
Gerrit-Change-Number: 19546
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 Mar 2023 14:05:21 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-11949: Add AVRO C++ 1.11.1 version
Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19546 )
Change subject: IMPALA-11949: Add AVRO C++ 1.11.1 version
......................................................................
Patch Set 2:
Looks like I do not have merge permission for native-toolchain repository, could someone submit it please?
--
To view, visit http://gerrit.cloudera.org:8080/19546
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I307247cdf19ea8b9a97248624111bdaa05dd8496
Gerrit-Change-Number: 19546
Gerrit-PatchSet: 2
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 Mar 2023 14:06:41 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-11949: Add AVRO C++ 1.11.1 version
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/19546 )
Change subject: IMPALA-11949: Add AVRO C++ 1.11.1 version
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19546/1/buildall.sh
File buildall.sh:
http://gerrit.cloudera.org:8080/#/c/19546/1/buildall.sh@297
PS1, Line 297: export BOOST_VERSION=1.74.0-p1
Nit: just wondering: is there a reason why BOOST_VERSION cannot be passed inline (just like AVRO_VERSION) and needs a subhsell here?
It's not a blocker for me, just being curious.
--
To view, visit http://gerrit.cloudera.org:8080/19546
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I307247cdf19ea8b9a97248624111bdaa05dd8496
Gerrit-Change-Number: 19546
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Feb 2023 15:44:57 +0000
Gerrit-HasComments: Yes
[native-toolchain-CR] IMPALA-11949: Add AVRO C++ 1.11.1 version
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19546 )
Change subject: IMPALA-11949: Add AVRO C++ 1.11.1 version
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19546/1/buildall.sh
File buildall.sh:
http://gerrit.cloudera.org:8080/#/c/19546/1/buildall.sh@297
PS1, Line 297: export BOOST_VERSION=1.74.0-p1
> The only reason I did it like this because this is how dependency versions
It looks to me like a pattern so it's easy to see the version that's being built where it's invoked, while dependency versions are placed before the build lines. So done for readability.
--
To view, visit http://gerrit.cloudera.org:8080/19546
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I307247cdf19ea8b9a97248624111bdaa05dd8496
Gerrit-Change-Number: 19546
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Mar 2023 18:19:46 +0000
Gerrit-HasComments: Yes
[native-toolchain-CR] IMPALA-11949: Add AVRO C++ 1.11.1 version
Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19546 )
Change subject: IMPALA-11949: Add AVRO C++ 1.11.1 version
......................................................................
Patch Set 3:
Never mind, it worked.
--
To view, visit http://gerrit.cloudera.org:8080/19546
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I307247cdf19ea8b9a97248624111bdaa05dd8496
Gerrit-Change-Number: 19546
Gerrit-PatchSet: 3
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 Mar 2023 14:07:34 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-11949: Add AVRO C++ 1.11.1 version
Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19546 )
Change subject: IMPALA-11949: Add AVRO C++ 1.11.1 version
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/19546
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I307247cdf19ea8b9a97248624111bdaa05dd8496
Gerrit-Change-Number: 19546
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 Mar 2023 14:05:54 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-11949: Add AVRO C++ 1.11.1 version
Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19546 )
Change subject: IMPALA-11949: Add AVRO C++ 1.11.1 version
......................................................................
Patch Set 1: -Verified
Thank you for the review Laszlo and Michael.
--
To view, visit http://gerrit.cloudera.org:8080/19546
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I307247cdf19ea8b9a97248624111bdaa05dd8496
Gerrit-Change-Number: 19546
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 Mar 2023 14:05:50 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-11949: Add AVRO C++ 1.11.1 version
Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19546 )
Change subject: IMPALA-11949: Add AVRO C++ 1.11.1 version
......................................................................
Patch Set 2: Verified+1 Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19546
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I307247cdf19ea8b9a97248624111bdaa05dd8496
Gerrit-Change-Number: 19546
Gerrit-PatchSet: 2
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 Mar 2023 14:06:47 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-11949: Add AVRO C++ 1.11.1 version
Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19546 )
Change subject: IMPALA-11949: Add AVRO C++ 1.11.1 version
......................................................................
IMPALA-11949: Add AVRO C++ 1.11.1 version
This patch adds a new AVRO version 1.11.1 and new build files for AVRO
C++. Until the integration is finished, for backward compatibility, both
AVRO C and AVRO C++ will be part of the toolchain.
The upgrade is necessary to support logical types, which is required
for Iceberg DECIMAL types. The AVRO C library has not been meaningfully
developed for 3 years now and it does not support logical types,
meanwhile the C++ library is still under development and supports the
necessary types.
Change-Id: I307247cdf19ea8b9a97248624111bdaa05dd8496
Reviewed-on: http://gerrit.cloudera.org:8080/19546
Reviewed-by: Tamas Mate <tm...@apache.org>
Tested-by: Tamas Mate <tm...@apache.org>
---
M buildall.sh
A source/avro/avro-1.11.1-patches/0001-fix-cpp-build-error.patch
A source/avro/build-cpp.sh
3 files changed, 683 insertions(+), 0 deletions(-)
Approvals:
Tamas Mate: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/19546
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I307247cdf19ea8b9a97248624111bdaa05dd8496
Gerrit-Change-Number: 19546
Gerrit-PatchSet: 3
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[native-toolchain-CR] IMPALA-11949: Add AVRO C++ 1.11.1 version
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/19546 )
Change subject: IMPALA-11949: Add AVRO C++ 1.11.1 version
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19546/1/buildall.sh
File buildall.sh:
http://gerrit.cloudera.org:8080/#/c/19546/1/buildall.sh@297
PS1, Line 297: export BOOST_VERSION=1.74.0-p1
> It looks to me like a pattern so it's easy to see the version that's being
Ack
--
To view, visit http://gerrit.cloudera.org:8080/19546
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I307247cdf19ea8b9a97248624111bdaa05dd8496
Gerrit-Change-Number: 19546
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Mar 2023 17:39:18 +0000
Gerrit-HasComments: Yes
[native-toolchain-CR] IMPALA-11949: Add AVRO C++ 1.11.1 version
Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19546 )
Change subject: IMPALA-11949: Add AVRO C++ 1.11.1 version
......................................................................
Patch Set 1:
(1 comment)
Thank you for the review Laszlo!
http://gerrit.cloudera.org:8080/#/c/19546/1/buildall.sh
File buildall.sh:
http://gerrit.cloudera.org:8080/#/c/19546/1/buildall.sh@297
PS1, Line 297: export BOOST_VERSION=1.74.0-p1
> Nit: just wondering: is there a reason why BOOST_VERSION cannot be passed i
The only reason I did it like this because this is how dependency versions are passed to other applications as well. I assumed that it is to avoid setting a version unexpectedly for other applications.
--
To view, visit http://gerrit.cloudera.org:8080/19546
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I307247cdf19ea8b9a97248624111bdaa05dd8496
Gerrit-Change-Number: 19546
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Mar 2023 12:43:37 +0000
Gerrit-HasComments: Yes