You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/10/07 12:09:25 UTC

[GitHub] [iotdb] HeimingZ opened a new pull request #4083: Fix test bug caused by restart error of virtual storage groups

HeimingZ opened a new pull request #4083:
URL: https://github.com/apache/iotdb/pull/4083


   Recently, i see following error message in the IoTDBCompleteIT's log:
   
   ![IoTDBCompleteIT error](https://user-images.githubusercontent.com/43991780/136377944-18753036-d0b7-44a5-808d-c714dd4f07c9.jpg)
   
   To resolve this error, there are two places to modify:
   
   Firstly, It is dangerous that IoTDBCompleteIT uses HashVirtualPartitioner's setStorageGroupNum method to set the number of virtual storage groups, because VirtualStorageGroupManager initializes StorageGroupProcessor array when it's constructed and the call of setStorageGroupNum method will cause sg num conflicts between HashVirtualPartitioner and VirtualStorageGroupManager, then throw ArrayIndexOutOfBoundsException. So, i remove the setStorageGroupNum method of HashVirtualPartitioner.
   
   Secondly, the restart of StorageEngine in EnvironmentUtils.restartDaemon() is confusing because the start method only start timed service except the initialization of storage groups. So, i move the initialization of storage groups in StorageEngine from constructor to start method. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] SteveYurongSu commented on pull request #4083: [IOTDB-1742] Fix test bug caused by restart error of virtual storage groups

Posted by GitBox <gi...@apache.org>.

SteveYurongSu commented on pull request #4083:
URL: https://github.com/apache/iotdb/pull/4083#issuecomment-938284569


   Closes issue [IOTDB-1742](https://issues.apache.org/jira/projects/IOTDB/issues/IOTDB-1742?filter=allopenissues).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] HTHou merged pull request #4083: [IOTDB-1742] Fix test bug caused by restart error of virtual storage groups

Posted by GitBox <gi...@apache.org>.

HTHou merged pull request #4083:
URL: https://github.com/apache/iotdb/pull/4083


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org